Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Rules > Rule Detail][SCREEN READER]: Abbreviations must be readaloud correctly #182417

Merged
merged 9 commits into from
May 10, 2024
Merged

fix: [Rules > Rule Detail][SCREEN READER]: Abbreviations must be readaloud correctly #182417

merged 9 commits into from
May 10, 2024

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented May 2, 2024 •
edited
Loading

Closes: https://github.com/elastic/security-team/issues/8649
Closes: https://github.com/elastic/security-team/issues/8658

Description

The Schedule description list on Rule Detail views is announcing hours and minutes incorrectly to screen readers. VoiceOver announced 5m as "Five meters" and 1h as "1 eche". This confusion can be remedied by spelling out the whole word and hiding it visually. Screen shot and code sample attached.

Steps to recreate

  1. Open Detection Rules (SIEM)
  2. Click on a rule name to land on the detail view
  3. Start your preferred screen reader
  4. Jump down to the Schedule module and listen to the description list items

What was done?:

The IntervalAbbrScreenReader component was developed, and it was integrated into /rule_creation_ui/components/description_step/index.tsx and /rule_details/rule_schedule_section.tsx to handle the interval and from fields.

Screen:

image

DOM:

image

@alexwizp
Copy link
Contributor Author

alexwizp commented May 3, 2024

/ci

@elastic elastic deleted a comment from kibana-ci May 3, 2024
@alexwizp alexwizp added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detection Engine Security Solution Detection Engine Area v8.15.0 Feature:Detection Rules Anything related to Security Solution's Detection Rules Feature:Detection Rule Preview Security Solution Rule Preview release_note:skip Skip the PR/issue when compiling release notes labels May 3, 2024
@alexwizp
Copy link
Contributor Author

alexwizp commented May 3, 2024

/ci

1 similar comment
@alexwizp
Copy link
Contributor Author

alexwizp commented May 3, 2024

/ci

@elastic elastic deleted a comment from kibana-ci May 3, 2024
@alexwizp
Copy link
Contributor Author

alexwizp commented May 3, 2024

/ci

@alexwizp alexwizp marked this pull request as ready for review May 3, 2024 19:59
@alexwizp alexwizp requested review from a team as code owners May 3, 2024 19:59
@alexwizp alexwizp requested a review from nkhristinin May 3, 2024 19:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@alexwizp alexwizp requested a review from dplumlee May 3, 2024 19:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

dplumlee
dplumlee approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@dplumlee dplumlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule management changes LGTM

@alexwizp
Copy link
Contributor Author

alexwizp commented May 8, 2024

@nkhristinin could you please have a look?

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 5496 5498 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.1MB 15.1MB +5.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit 99813cf into elastic:main May 10, 2024
35 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkhristinin nkhristinin nkhristinin approved these changes

@dplumlee dplumlee dplumlee approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Detection Rule Preview Security Solution Rule Preview Feature:Detection Rules Anything related to Security Solution's Detection Rules release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexwizp @elasticmachine @kibana-ci @nkhristinin @dplumlee @kibanamachine