[Security Solution] Timeline : Disabling Timeline ESQL feature flag should disable ESQL Tab. #182816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logeekal
added
Team:Threat Hunting:Investigations
logeekal
changed the title
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
|
/ci |
michaelolo24
approved these changes
May 7, 2024
PhilippeOberti
approved these changes
May 7, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 8, 2024
…hould disable ESQL Tab. (elastic#182816) ## Summary handles elastic#182798 Recently there was PR : elastic#181616 which does not disable ES|QL tab in timeline even if feature flag is disabled when : - User has already created a ESQL Query in timeline and saved the timeline. This PR makes sure when below feature flag exists, then `ES|QL` tab will be definitely disabled even when user has a saved timeline with ES|QL Query in it. ```yaml xpack.securitySolution.enableExperimental: - timelineEsqlTabDisabled ``` ## Desk Testing Guidelines 1. Remove above Feature Flag 2. Go to Timeline and Create a Timeline with ESQL Query 3. Save the timeline. 4. Go To advanced Settings and search for `esql` and disable the `enableESQL` setting. 5. Go back to the timeline saved in step 3. 6. ✅ Assert that the `ES|QL` tab is still there. 7. ✅ Assert that the `ES|QL` tab is NOT there in a new timeline. 8. Add above feature flag - which disables the esql Tab. 9. Go back to the timeline saved in step 3. 10. ✅ Assert that the `ES|QL` tab is no longer there. 11. ✅ Assert that the `ES|QL` tab is NOT there in a new timeline. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit c43da3e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 8, 2024
… flag should disable ESQL Tab. (#182816) (#182905) # Backport This will backport the following commits from `main` to `8.14`: - [[Security Solution] Timeline : Disabling Timeline ESQL feature flag should disable ESQL Tab. (#182816)](#182816) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2024-05-08T06:21:30Z","message":"[Security Solution] Timeline : Disabling Timeline ESQL feature flag should disable ESQL Tab. (#182816)\n\n## Summary\r\n\r\nhandles https://github.com/elastic/kibana/issues/182798\r\n\r\nRecently there was PR : https://github.com/elastic/kibana/pull/181616\r\nwhich does not disable ES|QL tab in timeline even if feature flag is\r\ndisabled when :\r\n- User has already created a ESQL Query in timeline and saved the\r\ntimeline.\r\n\r\nThis PR makes sure when below feature flag exists, then `ES|QL` tab will\r\nbe definitely disabled even when user has a saved timeline with ES|QL\r\nQuery in it.\r\n\r\n```yaml\r\nxpack.securitySolution.enableExperimental:\r\n - timelineEsqlTabDisabled\r\n\r\n```\r\n\r\n## Desk Testing Guidelines\r\n\r\n1. Remove above Feature Flag\r\n2. Go to Timeline and Create a Timeline with ESQL Query\r\n3. Save the timeline.\r\n4. Go To advanced Settings and search for `esql` and disable the\r\n`enableESQL` setting.\r\n5. Go back to the timeline saved in step 3. \r\n6. ✅ Assert that the `ES|QL` tab is still there.\r\n7. ✅ Assert that the `ES|QL` tab is NOT there in a new timeline.\r\n8. Add above feature flag - which disables the esql Tab.\r\n9. Go back to the timeline saved in step 3.\r\n10. ✅ Assert that the `ES|QL` tab is no longer there.\r\n11. ✅ Assert that the `ES|QL` tab is NOT there in a new timeline.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"c43da3e4349a6bb13cdab507530efd926147c30b","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat Hunting:Investigations","backport:prev-minor","v8.14.0","v8.15.0"],"title":"[Security Solution] Timeline : Disabling Timeline ESQL feature flag should disable ESQL Tab. ","number":182816,"url":"https://github.com/elastic/kibana/pull/182816","mergeCommit":{"message":"[Security Solution] Timeline : Disabling Timeline ESQL feature flag should disable ESQL Tab. (#182816)\n\n## Summary\r\n\r\nhandles https://github.com/elastic/kibana/issues/182798\r\n\r\nRecently there was PR : https://github.com/elastic/kibana/pull/181616\r\nwhich does not disable ES|QL tab in timeline even if feature flag is\r\ndisabled when :\r\n- User has already created a ESQL Query in timeline and saved the\r\ntimeline.\r\n\r\nThis PR makes sure when below feature flag exists, then `ES|QL` tab will\r\nbe definitely disabled even when user has a saved timeline with ES|QL\r\nQuery in it.\r\n\r\n```yaml\r\nxpack.securitySolution.enableExperimental:\r\n - timelineEsqlTabDisabled\r\n\r\n```\r\n\r\n## Desk Testing Guidelines\r\n\r\n1. Remove above Feature Flag\r\n2. Go to Timeline and Create a Timeline with ESQL Query\r\n3. Save the timeline.\r\n4. Go To advanced Settings and search for `esql` and disable the\r\n`enableESQL` setting.\r\n5. Go back to the timeline saved in step 3. \r\n6. ✅ Assert that the `ES|QL` tab is still there.\r\n7. ✅ Assert that the `ES|QL` tab is NOT there in a new timeline.\r\n8. Add above feature flag - which disables the esql Tab.\r\n9. Go back to the timeline saved in step 3.\r\n10. ✅ Assert that the `ES|QL` tab is no longer there.\r\n11. ✅ Assert that the `ES|QL` tab is NOT there in a new timeline.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"c43da3e4349a6bb13cdab507530efd926147c30b"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182816","number":182816,"mergeCommit":{"message":"[Security Solution] Timeline : Disabling Timeline ESQL feature flag should disable ESQL Tab. (#182816)\n\n## Summary\r\n\r\nhandles https://github.com/elastic/kibana/issues/182798\r\n\r\nRecently there was PR : https://github.com/elastic/kibana/pull/181616\r\nwhich does not disable ES|QL tab in timeline even if feature flag is\r\ndisabled when :\r\n- User has already created a ESQL Query in timeline and saved the\r\ntimeline.\r\n\r\nThis PR makes sure when below feature flag exists, then `ES|QL` tab will\r\nbe definitely disabled even when user has a saved timeline with ES|QL\r\nQuery in it.\r\n\r\n```yaml\r\nxpack.securitySolution.enableExperimental:\r\n - timelineEsqlTabDisabled\r\n\r\n```\r\n\r\n## Desk Testing Guidelines\r\n\r\n1. Remove above Feature Flag\r\n2. Go to Timeline and Create a Timeline with ESQL Query\r\n3. Save the timeline.\r\n4. Go To advanced Settings and search for `esql` and disable the\r\n`enableESQL` setting.\r\n5. Go back to the timeline saved in step 3. \r\n6. ✅ Assert that the `ES|QL` tab is still there.\r\n7. ✅ Assert that the `ES|QL` tab is NOT there in a new timeline.\r\n8. Add above feature flag - which disables the esql Tab.\r\n9. Go back to the timeline saved in step 3.\r\n10. ✅ Assert that the `ES|QL` tab is no longer there.\r\n11. ✅ Assert that the `ES|QL` tab is NOT there in a new timeline.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"c43da3e4349a6bb13cdab507530efd926147c30b"}}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
handles #182798
Recently there was PR : #181616 which does not disable ES|QL tab in timeline even if feature flag is disabled when :
This PR makes sure when below feature flag exists, then
ES|QLtab will be definitely disabled even when user has a saved timeline with ES|QL Query in it.Desk Testing Guidelines
esqland disable theenableESQLsetting.ES|QLtab is still there.ES|QLtab is NOT there in a new timeline.ES|QLtab is no longer there.ES|QLtab is NOT there in a new timeline.Checklist