Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] Migrate from listr to listr2 (#182683) #183141

Merged
merged 4 commits into from
May 14, 2024

Conversation

legrego
Copy link
Member

@legrego legrego commented May 10, 2024

Backport

This will backport the following commits from main to 7.17:

Questions ?

Please refer to the Backport tool documentation

## Summary

Migrates CLI tasks from `listr` to `listr2`. The former hasn't been
updated in a long time, and the community has moved on to `listr2`.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 40a1641)

# Conflicts:
#	packages/kbn-telemetry-tools/src/cli/run_telemetry_extract.ts
#	renovate.json
#	src/dev/i18n/tasks/extract_default_translations.ts
#	src/dev/i18n/tasks/extract_untracked_translations.ts
#	src/dev/run_i18n_check.ts
#	yarn.lock
@legrego legrego enabled auto-merge (squash) May 10, 2024 12:12
@legrego
Copy link
Member Author

legrego commented May 10, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1508 1519 +11
ml 1586 1597 +11
securitySolution 2568 2580 +12
total +34

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.4MB 1.4MB +2.4KB
ml 3.3MB 3.3MB +2.4KB
securitySolution 4.7MB 4.7MB +2.5KB
total +7.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego requested a review from jeramysoucy May 14, 2024 14:46
Copy link
Contributor

@jeramysoucy jeramysoucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legrego legrego merged commit 521be9f into elastic:7.17 May 14, 2024
27 checks passed
@legrego legrego deleted the backport/7.17/pr-182683 branch May 14, 2024 15:57
adelisle pushed a commit to Makila-AI/kibana that referenced this pull request Aug 5, 2024
This will backport the following commits from `main` to `7.17`:
- [Migrate from listr to listr2
(elastic#182683)](elastic#182683)

<!--- Backport version: 8.9.8 -->

Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Larry
Gregory","email":"larry.gregory@elastic.co"},"sourceCommit":{"committedDate":"2024-05-07T11:30:42Z","message":"Migrate
from listr to listr2 (elastic#182683)\n\n## Summary\r\n\r\nMigrates CLI tasks
from `listr` to `listr2`. The former hasn't been\r\nupdated in a long
time, and the community has moved on to
`listr2`.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"40a16413572140b857e52dc45b206558ee0f1c9c","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Security","release_note:skip","backport
missing","backport:all-open","ci:project-deploy-observability","Team:obs-ux-infra_services","apm:review","v8.15.0"],"number":182683,"url":"https://github.com/elastic/kibana/pull/182683","mergeCommit":{"message":"Migrate
from listr to listr2 (elastic#182683)\n\n## Summary\r\n\r\nMigrates CLI tasks
from `listr` to `listr2`. The former hasn't been\r\nupdated in a long
time, and the community has moved on to
`listr2`.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"40a16413572140b857e52dc45b206558ee0f1c9c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182683","number":182683,"mergeCommit":{"message":"Migrate
from listr to listr2 (elastic#182683)\n\n## Summary\r\n\r\nMigrates CLI tasks
from `listr` to `listr2`. The former hasn't been\r\nupdated in a long
time, and the community has moved on to
`listr2`.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"40a16413572140b857e52dc45b206558ee0f1c9c"}}]}]
BACKPORT-->

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants