Remove deprecated abab package
#183383
Merged
Remove deprecated abab package
#183383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
|
Signed |
|
buildkite test this |
jbudz
approved these changes
May 15, 2024
|
buildkite test this |
jeramysoucy
added
chore
backport:skip
|
@zyoshoka Thanks for the PR! Just curious how you discovered this. Did you use a scanning tool, or where you looking for specific packages manually? |
jeramysoucy
approved these changes
May 16, 2024
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
I just searched |
jeramysoucy
added
v8.1.4
v8.15.0
backport:all-open
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 16, 2024
## Summary This PR removes deprecated [`abab`](https://www.npmjs.com/package/abab) package. ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co> (cherry picked from commit 1ead6b5)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
|
@zyoshoka Could you try manually creating the 7.17 backport? |
kibanamachine
added a commit
that referenced
this pull request
May 16, 2024
# Backport This will backport the following commits from `main` to `8.14`: - [Remove deprecated `abab` package (#183383)](#183383) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"zyoshoka","email":"107108195+zyoshoka@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-05-16T10:48:26Z","message":"Remove deprecated `abab` package (#183383)\n\n## Summary\r\n\r\nThis PR removes deprecated [`abab`](https://www.npmjs.com/package/abab)\r\npackage.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"1ead6b533abbd90e8c022314ee0db1f9e4c84321","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","release_note:skip","💝community","backport:all-open","v8.15.0"],"title":"Remove deprecated `abab` package","number":183383,"url":"#183383 deprecated `abab` package (#183383)\n\n## Summary\r\n\r\nThis PR removes deprecated [`abab`](https://www.npmjs.com/package/abab)\r\npackage.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"1ead6b533abbd90e8c022314ee0db1f9e4c84321"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#183383 deprecated `abab` package (#183383)\n\n## Summary\r\n\r\nThis PR removes deprecated [`abab`](https://www.npmjs.com/package/abab)\r\npackage.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"1ead6b533abbd90e8c022314ee0db1f9e4c84321"}}]}] BACKPORT--> Co-authored-by: zyoshoka <107108195+zyoshoka@users.noreply.github.com>
|
Sorry, but this task seems tough to me because the Backport throws an error when Git cloning. |
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
May 17, 2024
## Summary This PR removes deprecated [`abab`](https://www.npmjs.com/package/abab) package. ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co> (cherry picked from commit 1ead6b5) # Conflicts: # yarn.lock
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jeramysoucy
added a commit
that referenced
this pull request
May 17, 2024
# Backport This will backport the following commits from `main` to `7.17`: - [Remove deprecated `abab` package (#183383)](#183383) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"zyoshoka","email":"107108195+zyoshoka@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-05-16T10:48:26Z","message":"Remove deprecated `abab` package (#183383)\n\n## Summary\r\n\r\nThis PR removes deprecated [`abab`](https://www.npmjs.com/package/abab)\r\npackage.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"1ead6b533abbd90e8c022314ee0db1f9e4c84321","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","release_note:skip","💝community","backport:all-open","v8.14.0","v8.15.0"],"number":183383,"url":"#183383 deprecated `abab` package (#183383)\n\n## Summary\r\n\r\nThis PR removes deprecated [`abab`](https://www.npmjs.com/package/abab)\r\npackage.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"1ead6b533abbd90e8c022314ee0db1f9e4c84321"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"#183618 Remove deprecated `abab` package (#183383) (#183618)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.14`:\n- [Remove deprecated `abab` package\n(#183383)](https://github.com/elastic/kibana/pull/183383)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT\n[{\"author\":{\"name\":\"zyoshoka\",\"email\":\"107108195+zyoshoka@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2024-05-16T10:48:26Z\",\"message\":\"Remove\ndeprecated `abab` package (#183383)\\n\\n## Summary\\r\\n\\r\\nThis PR removes\ndeprecated\n[`abab`](https://www.npmjs.com/package/abab)\\r\\npackage.\\r\\n\\r\\n### For\nmaintainers\\r\\n\\r\\n- [ ] This was checked for breaking API changes and\nwas\n[labeled\\r\\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\\r\\n\\r\\nCo-authored-by:\nJeramy Soucy\n<jeramy.soucy@elastic.co>\",\"sha\":\"1ead6b533abbd90e8c022314ee0db1f9e4c84321\",\"branchLabelMapping\":{\"^v8.15.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"chore\",\"release_note:skip\",\"💝community\",\"backport:all-open\",\"v8.15.0\"],\"title\":\"Remove\ndeprecated `abab`\npackage\",\"number\":183383,\"url\":\"#183383 `abab` package (#183383)\\n\\n## Summary\\r\\n\\r\\nThis PR removes\ndeprecated\n[`abab`](https://www.npmjs.com/package/abab)\\r\\npackage.\\r\\n\\r\\n### For\nmaintainers\\r\\n\\r\\n- [ ] This was checked for breaking API changes and\nwas\n[labeled\\r\\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\\r\\n\\r\\nCo-authored-by:\nJeramy Soucy\n<jeramy.soucy@elastic.co>\",\"sha\":\"1ead6b533abbd90e8c022314ee0db1f9e4c84321\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v8.15.0\",\"branchLabelMappingKey\":\"^v8.15.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"#183383 `abab` package (#183383)\\n\\n## Summary\\r\\n\\r\\nThis PR removes\ndeprecated\n[`abab`](https://www.npmjs.com/package/abab)\\r\\npackage.\\r\\n\\r\\n### For\nmaintainers\\r\\n\\r\\n- [ ] This was checked for breaking API changes and\nwas\n[labeled\\r\\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\\r\\n\\r\\nCo-authored-by:\nJeramy Soucy\n<jeramy.soucy@elastic.co>\",\"sha\":\"1ead6b533abbd90e8c022314ee0db1f9e4c84321\"}}]}]\nBACKPORT-->\n\nCo-authored-by: zyoshoka <107108195+zyoshoka@users.noreply.github.com>"}},{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#183383 deprecated `abab` package (#183383)\n\n## Summary\r\n\r\nThis PR removes deprecated [`abab`](https://www.npmjs.com/package/abab)\r\npackage.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"1ead6b533abbd90e8c022314ee0db1f9e4c84321"}}]}] BACKPORT--> Co-authored-by: zyoshoka <107108195+zyoshoka@users.noreply.github.com>
adelisle
pushed a commit
to Makila-AI/kibana
that referenced
this pull request
Aug 5, 2024
) # Backport This will backport the following commits from `main` to `7.17`: - [Remove deprecated `abab` package (elastic#183383)](elastic#183383) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"zyoshoka","email":"107108195+zyoshoka@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-05-16T10:48:26Z","message":"Remove deprecated `abab` package (elastic#183383)\n\n## Summary\r\n\r\nThis PR removes deprecated [`abab`](https://www.npmjs.com/package/abab)\r\npackage.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"1ead6b533abbd90e8c022314ee0db1f9e4c84321","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","release_note:skip","💝community","backport:all-open","v8.14.0","v8.15.0"],"number":183383,"url":"elastic#183383 deprecated `abab` package (elastic#183383)\n\n## Summary\r\n\r\nThis PR removes deprecated [`abab`](https://www.npmjs.com/package/abab)\r\npackage.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"1ead6b533abbd90e8c022314ee0db1f9e4c84321"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"elastic#183618 Remove deprecated `abab` package (elastic#183383) (elastic#183618)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.14`:\n- [Remove deprecated `abab` package\n(elastic#183383)](https://github.com/elastic/kibana/pull/183383)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT\n[{\"author\":{\"name\":\"zyoshoka\",\"email\":\"107108195+zyoshoka@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2024-05-16T10:48:26Z\",\"message\":\"Remove\ndeprecated `abab` package (elastic#183383)\\n\\n## Summary\\r\\n\\r\\nThis PR removes\ndeprecated\n[`abab`](https://www.npmjs.com/package/abab)\\r\\npackage.\\r\\n\\r\\n### For\nmaintainers\\r\\n\\r\\n- [ ] This was checked for breaking API changes and\nwas\n[labeled\\r\\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\\r\\n\\r\\nCo-authored-by:\nJeramy Soucy\n<jeramy.soucy@elastic.co>\",\"sha\":\"1ead6b533abbd90e8c022314ee0db1f9e4c84321\",\"branchLabelMapping\":{\"^v8.15.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"chore\",\"release_note:skip\",\"💝community\",\"backport:all-open\",\"v8.15.0\"],\"title\":\"Remove\ndeprecated `abab`\npackage\",\"number\":183383,\"url\":\"elastic#183383 `abab` package (elastic#183383)\\n\\n## Summary\\r\\n\\r\\nThis PR removes\ndeprecated\n[`abab`](https://www.npmjs.com/package/abab)\\r\\npackage.\\r\\n\\r\\n### For\nmaintainers\\r\\n\\r\\n- [ ] This was checked for breaking API changes and\nwas\n[labeled\\r\\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\\r\\n\\r\\nCo-authored-by:\nJeramy Soucy\n<jeramy.soucy@elastic.co>\",\"sha\":\"1ead6b533abbd90e8c022314ee0db1f9e4c84321\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v8.15.0\",\"branchLabelMappingKey\":\"^v8.15.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"elastic#183383 `abab` package (elastic#183383)\\n\\n## Summary\\r\\n\\r\\nThis PR removes\ndeprecated\n[`abab`](https://www.npmjs.com/package/abab)\\r\\npackage.\\r\\n\\r\\n### For\nmaintainers\\r\\n\\r\\n- [ ] This was checked for breaking API changes and\nwas\n[labeled\\r\\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\\r\\n\\r\\nCo-authored-by:\nJeramy Soucy\n<jeramy.soucy@elastic.co>\",\"sha\":\"1ead6b533abbd90e8c022314ee0db1f9e4c84321\"}}]}]\nBACKPORT-->\n\nCo-authored-by: zyoshoka <107108195+zyoshoka@users.noreply.github.com>"}},{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"elastic#183383 deprecated `abab` package (elastic#183383)\n\n## Summary\r\n\r\nThis PR removes deprecated [`abab`](https://www.npmjs.com/package/abab)\r\npackage.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"1ead6b533abbd90e8c022314ee0db1f9e4c84321"}}]}] BACKPORT--> Co-authored-by: zyoshoka <107108195+zyoshoka@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes deprecated
ababpackage.For maintainers