Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kbn 176803 cleanup 8.14 md5 check #183416

Merged
merged 2 commits into from
May 15, 2024

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented May 14, 2024

Summary

Follow-up of #176803

Now that 8.14 has been branched and it is about to be released, we can remove the test that ensures the HASH_TO_VERSION_MAP is aligned.

This PR also rolls back a few changes on the map that shouldn't have been performed, as they belong to 8.15.0.

@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes labels May 14, 2024
@gsoldevila gsoldevila requested a review from a team as a code owner May 14, 2024 15:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@gsoldevila gsoldevila added the Feature:FIPS FIPS mode for Kibana label May 14, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/core-saved-objects-base-server-internal 183 182 -1
Unknown metric groups

API count

id before after diff
@kbn/core-saved-objects-base-server-internal 226 225 -1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gsoldevila gsoldevila merged commit ed2e59f into elastic:main May 15, 2024
25 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels May 15, 2024
@gsoldevila gsoldevila added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.14.1 and removed backport:skip This commit does not require backporting labels Jun 6, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 6, 2024
## Summary

Follow-up of elastic#176803

Now that `8.14` has been branched and it is about to be released, we can
remove the test that ensures the `HASH_TO_VERSION_MAP` is aligned.

This PR also rolls back a few changes on the map that shouldn't have
been performed, as they belong to `8.15.0`.

(cherry picked from commit ed2e59f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 6, 2024
# Backport

This will backport the following commits from `main` to `8.14`:
- [Kbn 176803 cleanup 8.14 md5 check
(#183416)](#183416)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2024-05-15T09:37:42Z","message":"Kbn
176803 cleanup 8.14 md5 check (#183416)\n\n## Summary\r\n\r\nFollow-up
of #176803\r\n\r\nNow that `8.14` has been branched and it is about to
be released, we can\r\nremove the test that ensures the
`HASH_TO_VERSION_MAP` is aligned.\r\n\r\nThis PR also rolls back a few
changes on the map that shouldn't have\r\nbeen performed, as they belong
to
`8.15.0`.","sha":"ed2e59fea95b39dcc853f948ce122544515370f0","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","backport:prev-minor","Feature:FIPS","v8.15.0"],"title":"Kbn
176803 cleanup 8.14 md5
check","number":183416,"url":"https://github.com/elastic/kibana/pull/183416","mergeCommit":{"message":"Kbn
176803 cleanup 8.14 md5 check (#183416)\n\n## Summary\r\n\r\nFollow-up
of #176803\r\n\r\nNow that `8.14` has been branched and it is about to
be released, we can\r\nremove the test that ensures the
`HASH_TO_VERSION_MAP` is aligned.\r\n\r\nThis PR also rolls back a few
changes on the map that shouldn't have\r\nbeen performed, as they belong
to
`8.15.0`.","sha":"ed2e59fea95b39dcc853f948ce122544515370f0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/183416","number":183416,"mergeCommit":{"message":"Kbn
176803 cleanup 8.14 md5 check (#183416)\n\n## Summary\r\n\r\nFollow-up
of #176803\r\n\r\nNow that `8.14` has been branched and it is about to
be released, we can\r\nremove the test that ensures the
`HASH_TO_VERSION_MAP` is aligned.\r\n\r\nThis PR also rolls back a few
changes on the map that shouldn't have\r\nbeen performed, as they belong
to `8.15.0`.","sha":"ed2e59fea95b39dcc853f948ce122544515370f0"}}]}]
BACKPORT-->

Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:FIPS FIPS mode for Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.14.1 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants