Commits on May 14, 2024

1. [Reporting] Update to puppeteer 22.8.1 (elastic#183264) …

   ## Summary
   
   Quarterly update for puppeteer, the following change set updates
   puppeteer to version `22.8.1`.
   
   The chromium version required for this version of puppeteer is
   `124.0.6367.201` from revision `1274542`, as such the chromium binary
   included for windows and darwin platforms either match or were the
   closest revision to the expectation. The linux headless binary was built
   from commit `46cf136d27d50afd9c618d164a3b95b3b62d0027` of the same
   revision.
   
    ### Checklist
   
   <!--Delete any items that are not applicable to this PR. -->
   
   <!--
   - [ ] Any text added follows [EUI's writing
   guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
   sentence case text and includes [i18n
   support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
   - [ ]
   [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
   was added for features that require explanation or tutorials -->
   - [x] [Unit or functional
   tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
   were updated or added to match the most common scenarios
   
   <!--
   - [ ] [Flaky Test
   Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
   used on any tests changed
   - [ ] Any UI touched in this PR is usable by keyboard only (learn more
   about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
   - [ ] Any UI touched in this PR does not create any new axe failures
   (run axe in browser:
   [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
   [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
   - [ ] If a plugin configuration key changed, check if it needs to be
   allowlisted in the cloud and added to the [docker
   list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
   - [ ] This renders correctly on smaller devices using a responsive
   layout. (You can test this [in your
   browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
   - [ ] This was checked for [cross-browser
   compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
   
   ### Risk Matrix
   
   Delete this section if it is not applicable to this PR.
   
   Before closing this PR, invite QA, stakeholders, and other developers to
   identify risks that should be tested prior to the change/feature
   release.
   
   When forming the risk matrix, consider some of the following examples
   and how they may potentially impact the change:
   
   | Risk | Probability | Severity | Mitigation/Notes |
   
   |---------------------------|-------------|----------|-------------------------|
   | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
   | Low | High | Integration tests will verify that all features are still
   supported in non-default Kibana Space and when user switches between
   spaces. |
   | Multiple nodes&mdash;Elasticsearch polling might have race conditions
   when multiple Kibana nodes are polling for the same tasks. | High | Low
   | Tasks are idempotent, so executing them multiple times will not result
   in logical error, but will degrade performance. To test for this case we
   add plenty of unit tests around this logic and document manual testing
   procedure. |
   | Code should gracefully handle cases when feature X or plugin Y are
   disabled. | Medium | High | Unit tests will verify that any feature flag
   or plugin combination still results in our service operational. |
   | [See more potential risk
   examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
   
   ### For maintainers
   
   - [ ] This was checked for breaking API changes and was [labeled
   appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
   -->
   
   ### How to verify headless build on linux
   - clone the following repo
   https://github.com/tsullivan/kibana-dev-docker
   - pull this particular PR
   - follow the steps outlined in the repo, replacing any occurrence of
   `kibana-8.13.0-SNAPSHOT-linux-aarch64.tar.gz` from the repo above's step
   with the output of running build on this changeset.
   - before running step 4, modify the `kibana.yml` file from the
   `kibana-dev-docker` repo and include the following so we might be able
   to verify the version of chromium running;
      ```yaml
        logging.loggers:
          - name: plugins.reporting
            level: debug
      ```
   - complete the steps outlined in the README, you'll have a linux distro
   of kibana running on port `5601`
   - Attempt creating exports of PDF and PNG reports, in dashboard, canvas,
   and visualizations, on report creation attempt we would see a log output
   that prints out the chromium version similar to this;
   <img width="1581" alt="Screenshot 2024-05-14 at 10 27 52"
   src="https://github.com/elastic/kibana/assets/7893459/a13de1a1-c77e-44d9-bf74-7417b7d6cfd3">
   
   (cherry picked from commit ac2a751)

   

   eokoneyo committed May 14, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 5d6fe56
   • Browse repository at this point

   Copy the full SHA

   5d6fe56 View commit details

   Browse the repository at this point in the history