-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(slo): group by instance id #186131
feat(slo): group by instance id #186131
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
/ci |
13fa56b
to
ea2942a
Compare
2379694
to
7afa70a
Compare
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
LGTM! @kdelemme For some reason when I create an SLO with group by I get 0 SLO instances created. While I'm looking into this, could you make sure that the group by instance id option is added to the Group Overview Embeddable as well? I know it's not good how it is implemented at the moment, but we need to manually add the group by options in the embeddable as well. You can check how it was done when we added the Group by remote option as part of this issue, or feel free to refactor, so that it automatically picks up the group by options in the embeddable. |
@kdelemme I was able to generate some group by SLOs and grouping by instance id works well Shall we add the group by instance id in the Group Overview embeddable in a follow up PR? |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @kdelemme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! As discussed I approve this PR and we can handle the group by instance id in the Group embeddable in a follow up PR.
Resolves #186125
Summary
This PR adds the group by "SLO instance id" option.
I included the
slo.groupings
flattened field on the group summary response, so we can format the group name in a more user friendly way than just showing theslo.instanceId
field which is a coma separated string without the group keys.