Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slo): group by instance id #186131

Merged
merged 6 commits into from
Jun 19, 2024
Merged

Conversation

kdelemme
Copy link
Contributor

Resolves #186125

Summary

This PR adds the group by "SLO instance id" option.
I included the slo.groupings flattened field on the group summary response, so we can format the group name in a more user friendly way than just showing the slo.instanceId field which is a coma separated string without the group keys.

image

@kdelemme kdelemme self-assigned this Jun 12, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.15.0 labels Jun 12, 2024
@kdelemme
Copy link
Contributor Author

/ci

@kdelemme kdelemme marked this pull request as ready for review June 13, 2024 15:03
@kdelemme kdelemme requested a review from a team as a code owner June 13, 2024 15:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jun 13, 2024
@mgiota mgiota self-requested a review June 17, 2024 12:37
@mgiota
Copy link
Contributor

mgiota commented Jun 17, 2024

LGTM! @kdelemme For some reason when I create an SLO with group by I get 0 SLO instances created. While I'm looking into this, could you make sure that the group by instance id option is added to the Group Overview Embeddable as well?

I know it's not good how it is implemented at the moment, but we need to manually add the group by options in the embeddable as well. You can check how it was done when we added the Group by remote option as part of this issue, or feel free to refactor, so that it automatically picks up the group by options in the embeddable.

@mgiota
Copy link
Contributor

mgiota commented Jun 17, 2024

@kdelemme I was able to generate some group by SLOs and grouping by instance id works well

Screenshot 2024-06-17 at 20 45 24

Shall we add the group by instance id in the Group Overview embeddable in a follow up PR?

Screenshot 2024-06-17 at 20 46 16

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 18, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #14 / Cases Attachment framework Attachment hooks Modal filters with multiple selection

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
slo 854 855 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
slo 862.6KB 863.3KB +777.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 123.0KB 123.1KB +71.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As discussed I approve this PR and we can handle the group by instance id in the Group embeddable in a follow up PR.

@kdelemme kdelemme merged commit c0b65d6 into elastic:main Jun 19, 2024
23 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 19, 2024
seanrathier pushed a commit to seanrathier/kibana that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SLO] group by instanceid
6 participants