Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Entity Analytics] Remove internal asset criticality APIs #188108

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Jul 11, 2024

Summary

Closes #186959

Remove internal asset criticality APIs as we have public versions which were added in #186169

@hop-dev
Copy link
Contributor Author

hop-dev commented Jul 11, 2024

/ci

@hop-dev hop-dev force-pushed the delete-internal-asset-crit-apis branch from 4be9372 to 7500f38 Compare July 11, 2024 14:15
@elasticmachine
Copy link
Contributor

@hop-dev
Copy link
Contributor Author

hop-dev commented Jul 11, 2024

/ci

@hop-dev hop-dev self-assigned this Aug 1, 2024
@hop-dev hop-dev added release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team labels Aug 1, 2024
@hop-dev hop-dev marked this pull request as ready for review August 1, 2024 13:45
@hop-dev hop-dev requested a review from a team as a code owner August 1, 2024 13:45
@hop-dev hop-dev requested a review from machadoum August 1, 2024 13:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

@hop-dev
Copy link
Contributor Author

hop-dev commented Aug 1, 2024

@elasticmachine merge upstream

@hop-dev
Copy link
Contributor Author

hop-dev commented Aug 1, 2024

@elasticmachine merge upstream

@hop-dev
Copy link
Contributor Author

hop-dev commented Aug 1, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #56 / security app - login selector Basic functionality can login anonymously preserving original URL

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

Copy link
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Happy to see many deleted lines 🔥 🔥 🔥

@hop-dev hop-dev merged commit 920a40c into elastic:main Aug 2, 2024
40 checks passed
@hop-dev hop-dev deleted the delete-internal-asset-crit-apis branch August 2, 2024 08:35
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Entity Analytics] Delete internal asset criticality APIs
5 participants