Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Add cypress for expandable flyout previews #188117

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

christineweng
Copy link
Contributor

@christineweng christineweng commented Jul 11, 2024

Summary

This PR adds cypress test for the new preview panels that were recently added (#186857)

Checklist

@christineweng christineweng added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team v8.15.0 v8.16.0 labels Jul 11, 2024
@christineweng christineweng self-assigned this Jul 11, 2024
@christineweng christineweng requested review from a team as code owners July 11, 2024 15:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

Copy link
Contributor

@lgestc lgestc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just skimmed through this but looks okay :)

@elasticmachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

History

cc @christineweng

@christineweng christineweng merged commit ff93b41 into elastic:main Jul 17, 2024
39 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 17, 2024
…ic#188117)

## Summary

This PR adds cypress test for the new preview panels that were recently
added (elastic#186857)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit ff93b41)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 17, 2024
…#188117) (#188570)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Security Solution] Add cypress for expandable flyout previews
(#188117)](#188117)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-07-17T17:27:37Z","message":"[Security
Solution] Add cypress for expandable flyout previews (#188117)\n\n##
Summary\r\n\r\nThis PR adds cypress test for the new preview panels that
were recently\r\nadded
(https://github.com/elastic/kibana/pull/186857)\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"ff93b415a5e3738be0d64c3e03419d51e8afe621","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting","Team:Threat
Hunting:Investigations","v8.15.0","v8.16.0"],"title":"[Security
Solution] Add cypress for expandable flyout
previews","number":188117,"url":"https://github.com/elastic/kibana/pull/188117","mergeCommit":{"message":"[Security
Solution] Add cypress for expandable flyout previews (#188117)\n\n##
Summary\r\n\r\nThis PR adds cypress test for the new preview panels that
were recently\r\nadded
(https://github.com/elastic/kibana/pull/186857)\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"ff93b415a5e3738be0d64c3e03419d51e8afe621"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188117","number":188117,"mergeCommit":{"message":"[Security
Solution] Add cypress for expandable flyout previews (#188117)\n\n##
Summary\r\n\r\nThis PR adds cypress test for the new preview panels that
were recently\r\nadded
(https://github.com/elastic/kibana/pull/186857)\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"ff93b415a5e3738be0d64c3e03419d51e8afe621"}}]}]
BACKPORT-->

Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.15.0 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants