[Security Solution] Fix - Notes Flyout Product Feedback #188129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logeekal
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
logeekal
changed the title
PhilippeOberti
approved these changes
Jul 12, 2024
logeekal
added
v8.16.0
backport:prev-minor
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
logeekal
added a commit
to logeekal/kibana
that referenced
this pull request
Jul 16, 2024
# Summary Fixes below bugs based on feedback from @paulewing. ## Event Details Toggle in Notes @paulewing requested to remove the event toggle |Before|After| |---|---| || | ## Notes Flyout remains open when switching tabs |Before|After| |---|---| |<video src="https://github.com/elastic/kibana/assets/7485038/4228d2d6-c2ad-40dc-9e6c-ec049f834e8f" />|<video src="https://github.com/elastic/kibana/assets/7485038/0e010c22-4539-4428-9b1b-3b323a9f491c" />| ## Notes Flyout should be resizable As shown in above video, notes flyout is now resizable. (cherry picked from commit 309b907) # Conflicts: # x-pack/plugins/security_solution/public/timelines/components/timeline/tabs/query/query_tab_unified_components.test.tsx
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
logeekal
added a commit
that referenced
this pull request
Jul 16, 2024
…) (#188401) # Backport This will backport the following commits from `main` to `8.15`: - [[Security Solution] Fix - Notes Flyout Product Feedback (#188129)](#188129) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2024-07-12T17:20:19Z","message":"[Security Solution] Fix - Notes Flyout Product Feedback (#188129)\n\n# Summary\r\n\r\nFixes below bugs based on feedback from @paulewing.\r\n\r\n\r\n## Event Details Toggle in Notes\r\n\r\n@paulewing requested to remove the event toggle \r\n\r\n|Before|After|\r\n|---|---|\r\n||\r\n|\r\n\r\n\r\n## Notes Flyout remains open when switching tabs\r\n|Before|After|\r\n|---|---|\r\n|<video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/4228d2d6-c2ad-40dc-9e6c-ec049f834e8f\"\r\n/>|<video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/0e010c22-4539-4428-9b1b-3b323a9f491c\"\r\n/>|\r\n\r\n\r\n## Notes Flyout should be resizable\r\n\r\nAs shown in above video, notes flyout is now resizable.","sha":"309b907e59df245236c24f7a3b121488da9dc3e4","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Timeline","Team:Threat Hunting:Investigations","backport:prev-minor","v8.16.0"],"number":188129,"url":"https://github.com/elastic/kibana/pull/188129","mergeCommit":{"message":"[Security Solution] Fix - Notes Flyout Product Feedback (#188129)\n\n# Summary\r\n\r\nFixes below bugs based on feedback from @paulewing.\r\n\r\n\r\n## Event Details Toggle in Notes\r\n\r\n@paulewing requested to remove the event toggle \r\n\r\n|Before|After|\r\n|---|---|\r\n||\r\n|\r\n\r\n\r\n## Notes Flyout remains open when switching tabs\r\n|Before|After|\r\n|---|---|\r\n|<video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/4228d2d6-c2ad-40dc-9e6c-ec049f834e8f\"\r\n/>|<video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/0e010c22-4539-4428-9b1b-3b323a9f491c\"\r\n/>|\r\n\r\n\r\n## Notes Flyout should be resizable\r\n\r\nAs shown in above video, notes flyout is now resizable.","sha":"309b907e59df245236c24f7a3b121488da9dc3e4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188129","number":188129,"mergeCommit":{"message":"[Security Solution] Fix - Notes Flyout Product Feedback (#188129)\n\n# Summary\r\n\r\nFixes below bugs based on feedback from @paulewing.\r\n\r\n\r\n## Event Details Toggle in Notes\r\n\r\n@paulewing requested to remove the event toggle \r\n\r\n|Before|After|\r\n|---|---|\r\n||\r\n|\r\n\r\n\r\n## Notes Flyout remains open when switching tabs\r\n|Before|After|\r\n|---|---|\r\n|<video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/4228d2d6-c2ad-40dc-9e6c-ec049f834e8f\"\r\n/>|<video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/0e010c22-4539-4428-9b1b-3b323a9f491c\"\r\n/>|\r\n\r\n\r\n## Notes Flyout should be resizable\r\n\r\nAs shown in above video, notes flyout is now resizable.","sha":"309b907e59df245236c24f7a3b121488da9dc3e4"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes below bugs based on feedback from @paulewing.
Event Details Toggle in Notes
@paulewing requested to remove the event toggle
Notes Flyout remains open when switching tabs
Bildschirmaufnahme.2024-07-11.um.17.54.18.mov
Bildschirmaufnahme.2024-07-11.um.17.56.19.mov
Notes Flyout should be resizable
As shown in above video, notes flyout is now resizable.