[Security Assistant] Fix langgraph issues #189287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
…bana into fix/langgraph-issues
|
/ci |
|
/ci |
spong
reviewed
Jul 30, 2024
x-pack/plugins/elastic_assistant/server/lib/langchain/graphs/default_assistant_graph/prompts.ts
Outdated
Show resolved
Hide resolved
spong
reviewed
Jul 30, 2024
x-pack/packages/kbn-langchain/server/language_models/gemini_chat.ts
Outdated
Show resolved
Hide resolved
|
/ci |
|
/ci |
patrykkopycinski
changed the title
patrykkopycinski
added
bug
adcoelho
approved these changes
Jul 31, 2024
spong
reviewed
Jul 31, 2024
Comment on lines
+44
to
+45
| const steps = await Promise.all( | ||
| castArray(state.agentOutcome as AgentAction)?.map(async (action) => { |
There was a problem hiding this comment.
note: This fixes the multiple tool call code path which was previously not working. So now if the LLM chooses multiple tools at once (only Bedrock right now, OpenAI supports it as well, but not via langchain chatmodel IIRC), both will execute.
spong
reviewed
Jul 31, 2024
x-pack/plugins/elastic_assistant/server/lib/langchain/graphs/default_assistant_graph/index.ts
Show resolved
Hide resolved
spong
reviewed
Jul 31, 2024
x-pack/packages/kbn-langchain/server/language_models/bedrock_chat.ts
Outdated
Show resolved
Hide resolved
spong
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Checked out, tested locally, code reviewed, and paired a bit with @patrykkopycinski on the changes here -- LGTM!
Thanks for being strategic here with these fixes Patryk, appreciate it! 
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 31, 2024
## Summary - Fixed `Regenerate` button for Gemini - Fixed auto title functionality - Enabled `assistantBedrockChat` by default --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 0be8295)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 31, 2024
# Backport This will backport the following commits from `main` to `8.15`: - [[Security Assistant] Fix langgraph issues (#189287)](#189287) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Patryk Kopyciński","email":"contact@patrykkopycinski.com"},"sourceCommit":{"committedDate":"2024-07-31T20:32:29Z","message":"[Security Assistant] Fix langgraph issues (#189287)\n\n## Summary\r\n\r\n- Fixed `Regenerate` button for Gemini\r\n- Fixed auto title functionality\r\n- Enabled `assistantBedrockChat` by default\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"0be8295ed0028870074772c8d82093376482c4eb","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","ci:cloud-deploy","v8.15.0","v8.16.0"],"title":"[Security Assistant] Fix langgraph issues","number":189287,"url":"https://github.com/elastic/kibana/pull/189287","mergeCommit":{"message":"[Security Assistant] Fix langgraph issues (#189287)\n\n## Summary\r\n\r\n- Fixed `Regenerate` button for Gemini\r\n- Fixed auto title functionality\r\n- Enabled `assistantBedrockChat` by default\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"0be8295ed0028870074772c8d82093376482c4eb"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189287","number":189287,"mergeCommit":{"message":"[Security Assistant] Fix langgraph issues (#189287)\n\n## Summary\r\n\r\n- Fixed `Regenerate` button for Gemini\r\n- Fixed auto title functionality\r\n- Enabled `assistantBedrockChat` by default\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"0be8295ed0028870074772c8d82093376482c4eb"}}]}] BACKPORT--> Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Regeneratebutton for GeminiassistantBedrockChatby default