[UnifiedDocViewer] Filter on field name and value in expanded document view #192299

jughosta · 2024-09-06T18:51:08Z

Closes [UnifiedDocViewer] Filter on field name and value in expanded document view #163275

Summary

With this PR users can search by field value (raw and formatted) in DocViewer flyout.

Checklist

Unit or functional tests were updated or added to match the most common scenarios
This was checked for cross-browser compatibility

jughosta · 2024-09-06T18:51:23Z

/ci

…to 163275-search-by-field-value

…eld-value # Conflicts: # packages/kbn-unified-data-table/src/types.ts

…-fix'

elasticmachine · 2024-09-13T14:22:43Z

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

PhilippeOberti

LGTM for the Threat Hunting Investigations team

l-suarez

It looks good from the design perspective.

Note: With the highlighting we do on fields we also add a background color, but with values we can't just highlight only the exact letters, and adding a background color will create too much visual noise. Highlighting only the exact letters would be better, as we do with the Fields but we understand the technical limitations to do so now.

ryankeairns

I see Laura already reviewed... I'll add her to kibana-design.

lukasolson

Still looking through the code, but in my testing I noticed a couple of strange behaviors:

When I search for something more than a few characters long, I can swap out the first character without it actually applying to the results:

Screen.Recording.2024-09-17.at.3.33.12.PM.mov

Also, when I type * once, it doesn't affect results, but if I add ** then it appears to highlight the entire entry:

Screen.Recording.2024-09-17.at.3.35.19.PM.mov

Contrast this with the behaviors on main (first character matters, only single * is required to highlight the whole field):

Screen.Recording.2024-09-17.at.3.36.03.PM.mov

lukasolson · 2024-09-17T21:24:35Z

src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table_cell.tsx

          isDetails={isDetails}
+          isHighLighted={Boolean(


Suggested change

isHighLighted={Boolean(

isHighlighted={Boolean(

Updated via b20c54e

…eld-value

jughosta · 2024-09-19T10:20:24Z

Hi @lukasolson,

Thanks for reviewing and testing! I think the points you are describing are working as intended according to #186894 and the length of the entered search terms. cc @mbondyra

In this PR I (hopefully) didn't change the filtering by field name, only added filtering by value. And for value filtering I used simply includes on strings as field values can consist of any characters (including *).

lukasolson

LGTM! Made just one very minor nit below.

lukasolson · 2024-09-23T17:24:01Z

src/plugins/unified_doc_viewer/public/components/doc_viewer_table/field_row.ts

+
+  // format as html in a lazy way
+  public get formattedAsHtml(): string | undefined {
+    if (!this.#isFormattedAsHtml) {


Nit: Do we need a separate variable for this.#isFormattedAsHtml (and this.#isFormattedAsText) or can we just check if this.#formattedAsHtml is undefined?

@lukasolson I added it so we don't run the formatter again if it returns an empty result. Would it be okay to keep it this way?

Makes sense, yeah we can leave as is.

kibana-ci · 2024-09-26T07:11:35Z

💚 Build Succeeded

Buildkite Build
Commit: fce8a11

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`unifiedDocViewer`	218	219	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`unifiedDocViewer`	122.0KB	124.3KB	+2.3KB

History

💛 Build #237142 was flaky d3812d8
💛 Build #236989 was flaky 5d95f34
💛 Build #236595 was flaky a7c72c8
💛 Build #236326 was flaky 34164a1
💛 Build #235516 was flaky b20c54e
💛 Build #234349 was flaky 4528692

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

…t view (elastic#192299) - Closes elastic#163275 ## Summary With this PR users can search by field value (raw and formatted) in DocViewer flyout. <img width="569" alt="Screenshot 2024-09-06 at 20 49 57" src="https://github.com/user-attachments/assets/27e89017-4b8f-437b-9e00-b9a24eb88184"> <img width="544" alt="Screenshot 2024-09-06 at 20 50 09" src="https://github.com/user-attachments/assets/5086af87-df97-4fdb-84c3-f30c547678e0"> <img width="536" alt="Screenshot 2024-09-12 at 18 45 11" src="https://github.com/user-attachments/assets/abdfe31d-85a5-41de-bf05-88ecf0ac2b18"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 7b76160)

kibanamachine · 2024-09-26T07:16:23Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…ocument view (#192299) (#194094) # Backport This will backport the following commits from `main` to `8.x`: - [[UnifiedDocViewer] Filter on field name and value in expanded document view (#192299)](#192299)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>

…t view (elastic#192299) - Closes elastic#163275 ## Summary With this PR users can search by field value (raw and formatted) in DocViewer flyout. <img width="569" alt="Screenshot 2024-09-06 at 20 49 57" src="https://github.com/user-attachments/assets/27e89017-4b8f-437b-9e00-b9a24eb88184"> <img width="544" alt="Screenshot 2024-09-06 at 20 50 09" src="https://github.com/user-attachments/assets/5086af87-df97-4fdb-84c3-f30c547678e0"> <img width="536" alt="Screenshot 2024-09-12 at 18 45 11" src="https://github.com/user-attachments/assets/abdfe31d-85a5-41de-bf05-88ecf0ac2b18"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

…ocument view (elastic#192299) (elastic#194094) # Backport This will backport the following commits from `main` to `8.x`: - [[UnifiedDocViewer] Filter on field name and value in expanded document view (elastic#192299)](elastic#192299)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>

jughosta added 2 commits September 6, 2024 14:02

[Discover] Initial changes

4704854

[Discover] Allow to filter by field value in DocViewer

c184eff

jughosta added release_note:enhancement Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) Project:OneDiscover Enrich Discover with contextual awareness / Merge with Logs Explorer v8.16.0 labels Sep 6, 2024

jughosta self-assigned this Sep 6, 2024

kibanamachine and others added 14 commits September 6, 2024 19:04

[CI] Auto-commit changed files from 'node scripts/notice'

b565e49

[Discover] Fix field name prop

c6007aa

Merge remote-tracking branch 'origin/163275-search-by-field-value' in…

f28897e

…to 163275-search-by-field-value

Merge branch 'main' into 163275-search-by-field-value

858ea3e

Merge main

9d5b93c

Update highlighting

adcae38

Merge remote-tracking branch 'upstream/main' into 163275-search-by-fi…

0dfdaf1

…eld-value # Conflicts: # packages/kbn-unified-data-table/src/types.ts

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

ca708e1

…-fix'

Merge branch 'main' into 163275-search-by-field-value

7cf1f6d

Merge branch 'main' into 163275-search-by-field-value

c788504

[Discover] Update tests. Enable the highlight.

70cfa7a

[Discover] Add functional tests

f81fbef

[Discover] Simplify matching

b17c369

[Discover] Update tests

723adef

jughosta added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed v8.16.0 labels Sep 13, 2024

jughosta added 3 commits September 13, 2024 11:16

Merge branch 'main' into 163275-search-by-field-value

e7a330c

[Discover] Update tests

c373989

[Discover] Fix tests

ed83330

jughosta marked this pull request as ready for review September 13, 2024 14:22

jughosta requested review from a team as code owners September 13, 2024 14:22

jughosta requested a review from a team as a code owner September 13, 2024 14:22

Merge branch 'main' into 163275-search-by-field-value

114f8b8

PhilippeOberti approved these changes Sep 13, 2024

View reviewed changes

Merge branch 'main' into 163275-search-by-field-value

4528692

l-suarez approved these changes Sep 16, 2024

View reviewed changes

ryankeairns approved these changes Sep 17, 2024

View reviewed changes

lukasolson reviewed Sep 17, 2024

View reviewed changes

jughosta added 2 commits September 19, 2024 12:07

Merge remote-tracking branch 'upstream/main' into 163275-search-by-fi…

3ca7127

…eld-value

[Discover] Rename to isHighlighted

b20c54e

Merge branch 'main' into 163275-search-by-field-value

34164a1

kertal requested a review from lukasolson September 23, 2024 12:40

lukasolson approved these changes Sep 23, 2024

View reviewed changes

jughosta added 4 commits September 24, 2024 12:00

Merge branch 'main' into 163275-search-by-field-value

a7c72c8

Merge branch 'main' into 163275-search-by-field-value

5d95f34

Merge branch 'main' into 163275-search-by-field-value

d3812d8

Merge branch 'main' into 163275-search-by-field-value

fce8a11

jughosta enabled auto-merge (squash) September 26, 2024 05:53

jughosta merged commit 7b76160 into elastic:main Sep 26, 2024
20 checks passed

kibanamachine added the v9.0.0 label Sep 26, 2024

kibanamachine mentioned this pull request Sep 26, 2024

[8.x] [UnifiedDocViewer] Filter on field name and value in expanded document view (#192299) #194094

Merged

kibanamachine added the v8.16.0 label Sep 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[UnifiedDocViewer] Filter on field name and value in expanded document view #192299

[UnifiedDocViewer] Filter on field name and value in expanded document view #192299

jughosta commented Sep 6, 2024 •

edited by kibanamachine

Loading

jughosta commented Sep 6, 2024

elasticmachine commented Sep 13, 2024

PhilippeOberti left a comment

l-suarez left a comment

ryankeairns left a comment

lukasolson left a comment

lukasolson Sep 17, 2024

jughosta Sep 19, 2024

jughosta commented Sep 19, 2024 •

edited

Loading

lukasolson left a comment

lukasolson Sep 23, 2024

jughosta Sep 24, 2024

lukasolson Sep 25, 2024

kibana-ci commented Sep 26, 2024

kibanamachine commented Sep 26, 2024

[UnifiedDocViewer] Filter on field name and value in expanded document view #192299

[UnifiedDocViewer] Filter on field name and value in expanded document view #192299

Conversation

jughosta commented Sep 6, 2024 • edited by kibanamachine Loading

Summary

Checklist

jughosta commented Sep 6, 2024

elasticmachine commented Sep 13, 2024

PhilippeOberti left a comment

Choose a reason for hiding this comment

l-suarez left a comment

Choose a reason for hiding this comment

ryankeairns left a comment

Choose a reason for hiding this comment

lukasolson left a comment

Choose a reason for hiding this comment

lukasolson Sep 17, 2024

Choose a reason for hiding this comment

jughosta Sep 19, 2024

Choose a reason for hiding this comment

jughosta commented Sep 19, 2024 • edited Loading

lukasolson left a comment

Choose a reason for hiding this comment

lukasolson Sep 23, 2024

Choose a reason for hiding this comment

jughosta Sep 24, 2024

Choose a reason for hiding this comment

lukasolson Sep 25, 2024

Choose a reason for hiding this comment

kibana-ci commented Sep 26, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

kibanamachine commented Sep 26, 2024

💚 All backports created successfully

Questions ?

jughosta commented Sep 6, 2024 •

edited by kibanamachine

Loading

jughosta commented Sep 19, 2024 •

edited

Loading