[DOCS][API] Add /api/fleet to Fleet API paths #192652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
added
Team:Fleet
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Pinging @elastic/fleet (Team:Fleet) |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
juliaElastic
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
LGTM
FYI we are moving to use kibana's schema generation, so these bundles will be generated: #184685
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Sep 12, 2024
(cherry picked from commit 94aac7a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
lcawl
added a commit
that referenced
this pull request
Sep 12, 2024
# Backport This will backport the following commits from `main` to `8.15`: - [[DOCS][API] Add /api/fleet to Fleet API paths (#192652)](#192652) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2024-09-12T14:03:40Z","message":"[DOCS][API] Add /api/fleet to Fleet API paths (#192652)","sha":"94aac7ad09900407f70656e9e5516806f69cf68e","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","docs","v8.16.0","v8.15.2"],"number":192652,"url":"https://github.com/elastic/kibana/pull/192652","mergeCommit":{"message":"[DOCS][API] Add /api/fleet to Fleet API paths (#192652)","sha":"94aac7ad09900407f70656e9e5516806f69cf68e"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192652","number":192652,"mergeCommit":{"message":"[DOCS][API] Add /api/fleet to Fleet API paths (#192652)","sha":"94aac7ad09900407f70656e9e5516806f69cf68e"}},{"branch":"8.15","label":"v8.15.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
1 task
gergoabraham
pushed a commit
to gergoabraham/kibana
that referenced
this pull request
Sep 13, 2024
markov00
pushed a commit
to markov00/kibana
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves
api/fleetfrom the OpenAPI servers definition into the path definition, since it's being lost when we merge this file into all the rest of the Kibana APIs (for example: https://www.elastic.co/docs/api/doc/kibana/operation/operation-new-agent-action). I've also commented out theinternal/fleetendpoint since it seemed unlikely we want this published publicly. If that's an incorrect assumption, we can uncomment and re-generate the bundles.