Move all reporting tests into their own folder and add chromium tests #19330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacey-gammon
added
test
:Sharing
v7.0.0
v6.4.0
(Deprecated) Feature:Reporting
stacey-gammon
force-pushed
the
2018-05-chromium-tests
branch
3 times, most recently
from
2c77f78
to
34fe3b3
Compare
💔 Build Failed |
stacey-gammon
changed the title
|
Failed on chromium api tests again: Should have been fixed with that spawnSync curl command. Agent Info, in case this is dependent on the jenkins agent:
Also looks like I need to conditionally output the curl logs so it doesn't spit out if verbose logging is off. |
💔 Build Failed |
stacey-gammon
force-pushed
the
2018-05-chromium-tests
branch
2 times, most recently
from
cfef13f
to
af6de3d
Compare
💔 Build Failed |
💚 Build Succeeded |
nreese
approved these changes
May 24, 2018
| // See https://github.com/elastic/kibana/issues/19351 for why this is necessary. Long story short, on certain | ||
| // linux platforms (fwiw, we have only experienced this on jenkins agents) the first bootup of chromium takes | ||
| // a long time doing something with fontconfig packages loading up a cache. The cdp command will timeout | ||
| // if we don't want for this manually. Note that this may still timeout based on the value of |
There was a problem hiding this comment.
is "want" supposed to be "wait"?
💔 Build Failed |
|
strange error that looks unrelated: |
stacey-gammon
force-pushed
the
2018-05-chromium-tests
branch
from
35048dd
to
757befd
Compare
…e left in since so many passes
…t instead of spawnsync and curl)
…e http.request code
stacey-gammon
force-pushed
the
2018-05-chromium-tests
branch
from
67184eb
to
2df0545
Compare
|
Rebased with master to make sure tests pass on the latest, since it's been awhile |
tylersmalley
approved these changes
Jun 5, 2018
|
|
||
| describe('chromium', () => { | ||
| before(async () => { | ||
| await esArchiver.load('../../../../test/functional/fixtures/es_archiver/dashboard/current/kibana'); |
There was a problem hiding this comment.
nit: could assign ../../../../test/functional/fixtures/es_archiver/dashboard/current to a variable and use a template literal.
💔 Build Failed |
💚 Build Succeeded |
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Jun 5, 2018
…elastic#19330) * Move all reporting tests into their own folder to allow for multiple kibana.yml configuration tests, including chromium * Add debugging and try to skip other tests an jenkins to speed things up * More debug output * more logging (remove other line which failed on jenkins) * Remove no sandbox flag, it doesn't help * Add fix for socket hangup and clean up tests * fix path to logstash_functional * Extend timeout for chromium, add verbose logging, add better comment, conditionally output curl command * fix path... again * Ah, other functional tests still need access to reporting page object, put it back * fix sp err * Add debug logs for screenshot stitching for png.bitblt error * Fix tests that don't pass logger to screenshotStitcher * Fix logger being undefined * Add more debug output * png has data, too much info to spit out * Add comment with link to issue for extra debug messages so they can be left in since so many passes * Dont use spawnSync with curl, use http.request instead, more support for it * Comment out chromium tests for now to avoid flakiness * Wait... lets at least make sure the other fix worked (the http.request instead of spawnsync and curl) * New http.request code doesn't seem to work on jenkins, timing out after 10 secs maybe * go back to spawnsync to see if it's an issue with the rxjs code or the http.request code * I think I figured it out... * Comment out tests to avoid flaky png error in the screenshot stitcher * Use a const for OSS archive path * use path.resolve correctly.
stacey-gammon
added a commit
that referenced
this pull request
Jun 6, 2018
…#19330) (#19690) * Move all reporting tests into their own folder to allow for multiple kibana.yml configuration tests, including chromium * Add debugging and try to skip other tests an jenkins to speed things up * More debug output * more logging (remove other line which failed on jenkins) * Remove no sandbox flag, it doesn't help * Add fix for socket hangup and clean up tests * fix path to logstash_functional * Extend timeout for chromium, add verbose logging, add better comment, conditionally output curl command * fix path... again * Ah, other functional tests still need access to reporting page object, put it back * fix sp err * Add debug logs for screenshot stitching for png.bitblt error * Fix tests that don't pass logger to screenshotStitcher * Fix logger being undefined * Add more debug output * png has data, too much info to spit out * Add comment with link to issue for extra debug messages so they can be left in since so many passes * Dont use spawnSync with curl, use http.request instead, more support for it * Comment out chromium tests for now to avoid flakiness * Wait... lets at least make sure the other fix worked (the http.request instead of spawnsync and curl) * New http.request code doesn't seem to work on jenkins, timing out after 10 secs maybe * go back to spawnsync to see if it's an issue with the rxjs code or the http.request code * I think I figured it out... * Comment out tests to avoid flaky png error in the screenshot stitcher * Use a const for OSS archive path * use path.resolve correctly.
kindsun
pushed a commit
that referenced
this pull request
Jun 12, 2018
…#19330) * Move all reporting tests into their own folder to allow for multiple kibana.yml configuration tests, including chromium * Add debugging and try to skip other tests an jenkins to speed things up * More debug output * more logging (remove other line which failed on jenkins) * Remove no sandbox flag, it doesn't help * Add fix for socket hangup and clean up tests * fix path to logstash_functional * Extend timeout for chromium, add verbose logging, add better comment, conditionally output curl command * fix path... again * Ah, other functional tests still need access to reporting page object, put it back * fix sp err * Add debug logs for screenshot stitching for png.bitblt error * Fix tests that don't pass logger to screenshotStitcher * Fix logger being undefined * Add more debug output * png has data, too much info to spit out * Add comment with link to issue for extra debug messages so they can be left in since so many passes * Dont use spawnSync with curl, use http.request instead, more support for it * Comment out chromium tests for now to avoid flakiness * Wait... lets at least make sure the other fix worked (the http.request instead of spawnsync and curl) * New http.request code doesn't seem to work on jenkins, timing out after 10 secs maybe * go back to spawnsync to see if it's an issue with the rxjs code or the http.request code * I think I figured it out... * Comment out tests to avoid flaky png error in the screenshot stitcher * Use a const for OSS archive path * use path.resolve correctly.
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Jun 25, 2018
…elastic#19330) * Move all reporting tests into their own folder to allow for multiple kibana.yml configuration tests, including chromium * Add debugging and try to skip other tests an jenkins to speed things up * More debug output * more logging (remove other line which failed on jenkins) * Remove no sandbox flag, it doesn't help * Add fix for socket hangup and clean up tests * fix path to logstash_functional * Extend timeout for chromium, add verbose logging, add better comment, conditionally output curl command * fix path... again * Ah, other functional tests still need access to reporting page object, put it back * fix sp err * Add debug logs for screenshot stitching for png.bitblt error * Fix tests that don't pass logger to screenshotStitcher * Fix logger being undefined * Add more debug output * png has data, too much info to spit out * Add comment with link to issue for extra debug messages so they can be left in since so many passes * Dont use spawnSync with curl, use http.request instead, more support for it * Comment out chromium tests for now to avoid flakiness * Wait... lets at least make sure the other fix worked (the http.request instead of spawnsync and curl) * New http.request code doesn't seem to work on jenkins, timing out after 10 secs maybe * go back to spawnsync to see if it's an issue with the rxjs code or the http.request code * I think I figured it out... * Comment out tests to avoid flaky png error in the screenshot stitcher * Use a const for OSS archive path * use path.resolve correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for us to test multiple kibana.yml configurations, including chromium versions.
Could also be considered a benefit in that reporting tests take a long time to complete, so if we decide to split out what is included in the jenkins ci vs integration tests, this will better isolate the code needed for that.
This also means we can set optimize.enabled to false for the other api tests which speed them up.
The majority of this change list is just moving code around. The only changes are that some of the tests are run now with the chromium option.
Fixes #19351