Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Obs Alerts table] Fix error on clicking alert reason message #193693

Merged
merged 2 commits into from
Sep 23, 2024
Merged

[Obs Alerts table] Fix error on clicking alert reason message #193693

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73b8d22
fix error on alerts table
benakansara Sep 23, 2024
12d7ac3
fix error for metric and inventory rules
benakansara Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 32 additions & 15 deletions ...on/observability/public/components/alert_overview/helpers/map_rules_params_with_flyout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,9 @@ export const mapRuleParamsWithFlyout = (alert: TopAlert): FlyoutThresholdData[]
switch (ruleId) {
case OBSERVABILITY_THRESHOLD_RULE_TYPE_ID:
return observedValues.map((observedValue, metricIndex) => {
const criteria = ruleCriteria[metricIndex] as CustomMetricExpressionParams;
const criteria = Array.isArray(ruleCriteria)
? (ruleCriteria[metricIndex] as CustomMetricExpressionParams)
: (ruleCriteria as CustomMetricExpressionParams);
const fields = criteria.metrics.map((metric) => metric.field || 'COUNT_AGG');
const comparator = criteria.comparator;
const threshold = criteria.threshold;
Expand Down Expand Up @@ -118,12 +120,20 @@ export const mapRuleParamsWithFlyout = (alert: TopAlert): FlyoutThresholdData[]

case METRIC_THRESHOLD_ALERT_TYPE_ID:
return observedValues.map((observedValue, metricIndex) => {
const criteria = ruleCriteria[metricIndex] as BaseMetricExpressionParams & {
metric: string;
customMetrics: Array<{
field?: string;
}>;
};
const criteria = Array.isArray(ruleCriteria)
? (ruleCriteria[metricIndex] as BaseMetricExpressionParams & {
metric: string;
customMetrics: Array<{
field?: string;
}>;
})
: (ruleCriteria as BaseMetricExpressionParams & {
metric: string;
customMetrics: Array<{
field?: string;
}>;
});

let fields: string[] = [];
const metric = criteria.metric;
const customMetric = criteria.customMetrics;
Expand Down Expand Up @@ -157,14 +167,21 @@ export const mapRuleParamsWithFlyout = (alert: TopAlert): FlyoutThresholdData[]

case METRIC_INVENTORY_THRESHOLD_ALERT_TYPE_ID:
return observedValues.map((observedValue, metricIndex) => {
const { threshold, customMetric, metric, comparator } = ruleCriteria[
metricIndex
] as BaseMetricExpressionParams & {
metric: string;
customMetric: {
field: string;
};
};
const criteria = Array.isArray(ruleCriteria)
? (ruleCriteria[metricIndex] as BaseMetricExpressionParams & {
metric: string;
customMetric: {
field: string;
};
})
: (ruleCriteria as BaseMetricExpressionParams & {
metric: string;
customMetric: {
field: string;
};
});

const { threshold, customMetric, metric, comparator } = criteria;
const metricField = customMetric?.field || metric;
const thresholdFormatted = threshold.map((thresholdToFormat) => {
if (
Expand Down
Loading