Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move component state from redux into observables #193783

Merged
merged 23 commits into from
Oct 2, 2024
Merged

move component state from redux into observables #193783

merged 23 commits into from
Oct 2, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Sep 23, 2024 •
edited by kibanamachine
Loading

null

@nreese
Copy link
Contributor Author

nreese commented Sep 25, 2024

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Sep 27, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Sep 27, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Sep 27, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Sep 27, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Sep 30, 2024

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Sep 30, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Sep 30, 2024

/ci

@nreese nreese added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Sep 30, 2024
@nreese nreese marked this pull request as ready for review September 30, 2024 19:00
@nreese nreese requested a review from a team as a code owner September 30, 2024 19:00
@nreese nreese added the release_note:skip Skip the PR/issue when compiling release notes label Sep 30, 2024
@Heenawter Heenawter self-requested a review October 1, 2024 14:19
@nreese
Copy link
Contributor Author

nreese commented Oct 2, 2024

@elasticmachine merge upstream

@nreese nreese requested a review from Heenawter October 2, 2024 01:09
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 530 534 +4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
dashboard 126 125 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 473.5KB 471.7KB -1.8KB
Unknown metric groups

API count

id before after diff
dashboard 131 130 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit dab01aa into elastic:main Oct 2, 2024
20 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11145942203

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 2, 2024
@nreese
move component state from redux into observables (elastic#193783)
47065b8 
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit dab01aa)
@kibanamachine kibanamachine mentioned this pull request Oct 2, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 2, 2024
@kibanamachine @nreese
[8.x] move component state from redux into observables (#193783) (#19…
bd99a3c 
…4718)

# Backport

This will backport the following commits from `main` to `8.x`:
- [move component state from redux into observables
(#193783)](#193783)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2024-10-02T14:37:44Z","message":"move
component state from redux into observables (#193783)\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"dab01aa27ed8a4f1bc6fe655346211355dfa5790","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","project:embeddableRebuild","v8.16.0","backport:version"],"title":"move
component state from redux into
observables","number":193783,"url":"https://github.com/elastic/kibana/pull/193783","mergeCommit":{"message":"move
component state from redux into observables (#193783)\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"dab01aa27ed8a4f1bc6fe655346211355dfa5790"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193783","number":193783,"mergeCommit":{"message":"move
component state from redux into observables (#193783)\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"dab01aa27ed8a4f1bc6fe655346211355dfa5790"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heenawter Heenawter Heenawter approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nreese @kibana-ci @kibanamachine @Heenawter @elasticmachine