Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [map embeddable] fix panel disappears from dashboard when canceling edit after dashboard save (#193911) #193929

Merged
merged 1 commit into from
Sep 24, 2024

Commits on Sep 24, 2024

  1. [map embeddable] fix panel disappears from dashboard when canceling e…

    …dit after dashboard save (elastic#193911)
    
    Part of elastic#193905. Broke work into
    separate PRs to backport map embeddable changes to 8.15.
    
    Resolves issue for Map embeddable. The problem is that Map embeddable is
    using a stale result from `parentApi.getAppContext`. Dashboard's
    `getAppContext` changes the `getCurrentPath` when the dashboard has a
    saved object id. By using the stale results, `getCurrentPath` returned
    `#/create` instead of `#/view/`.
    
    ### Test steps
    1. create new dashboard
    2. Click "Add panel" (problem also exists when using "Add from library")
    3. Select "Maps"
    4.  In editor, click "Save and return"
    5. Save dashboard
    6. Click "Edit" in panel context menu
    7. In editor, click "Cancel"
    8. Ensure map panel is still displayed in dashboard
    
    (cherry picked from commit 882b6fb)
    nreese committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    4d97bf3 View commit details
    Browse the repository at this point in the history