Commits on Sep 30, 2024

1. [Discover] [Unified Doc Viewer] Fix doc viewer not receiving focus on… …

   … open (elastic#191039)
   
   ## Summary
   
   This PR fixes an issue where the new resizable doc viewer push flyout
   was not receiving focus on open, resulting in the flyout having to be
   manually focused in before users can navigate between docs using the
   arrow keys. It also re-adds support for closing the flyout when pressing
   the escape key, improves overall focus management, ensures the proper
   a11y attributes are used when the push flyout is shown, and introduces a
   new set of functional tests for doc viewer keyboard navigation and a11y.
   
   Fixes elastic#190946.
   
   ### Checklist
   
   - [x] Any text added follows [EUI's writing
   guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
   sentence case text and includes [i18n
   support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
   - [ ]
   [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
   was added for features that require explanation or tutorials
   - [x] [Unit or functional
   tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
   were updated or added to match the most common scenarios
   - [ ] [Flaky Test
   Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
   used on any tests changed
   - [x] Any UI touched in this PR is usable by keyboard only (learn more
   about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
   - [x] Any UI touched in this PR does not create any new axe failures
   (run axe in browser:
   [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
   [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
   - [ ] If a plugin configuration key changed, check if it needs to be
   allowlisted in the cloud and added to the [docker
   list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
   - [x] This renders correctly on smaller devices using a responsive
   layout. (You can test this [in your
   browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
   - [x] This was checked for [cross-browser
   compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
   
   ### For maintainers
   
   - [ ] This was checked for breaking API changes and was [labeled
   appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
   
   ---------
   
   Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
   (cherry picked from commit 0ac6965)

   

   davismcphee committed Sep 30, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 5badfbc
   • Browse repository at this point

   Copy the full SHA

   5badfbc View commit details

   Browse the repository at this point in the history