Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Update grammars #194370

Merged
merged 2 commits into from
Sep 30, 2024
Merged

[ES|QL] Update grammars #194370

merged 2 commits into from
Sep 30, 2024

Conversation

kibanamachine
Copy link
Contributor

@kibanamachine kibanamachine commented Sep 30, 2024 •
edited
Loading

This PR updates the ES|QL grammars (lexer and parser) to match the latest version in Elasticsearch.

@kibanamachine kibanamachine requested a review from a team as a code owner September 30, 2024 04:10
@kibanamachine kibanamachine added release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana labels Sep 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana labels Sep 30, 2024
stratoula
stratoula approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of match command, LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #3 / Timeline rendering should trim kqlQueryExpression

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.4MB 3.4MB -1.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 94120d9 into main Sep 30, 2024
23 checks passed
@stratoula stratoula deleted the esql_grammar_sync_1727669391 branch September 30, 2024 07:39
@kibanamachine
Copy link
Contributor Author

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11101586945

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 30, 2024
@kibanamachine
[ES|QL] Update grammars (elastic#194370)
c02c79d 
This PR updates the ES|QL grammars (lexer and parser) to match the
latest version in Elasticsearch.

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
(cherry picked from commit 94120d9)
@kibanamachine kibanamachine mentioned this pull request Sep 30, 2024
Merged
@kibanamachine
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 30, 2024
@kibanamachine
[8.x] [ES|QL] Update grammars (#194370) (#194378)
d019f72 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Update grammars
(#194370)](#194370)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kibana
Machine","email":"42973632+kibanamachine@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-30T07:39:17Z","message":"[ES|QL]
Update grammars (#194370)\n\nThis PR updates the ES|QL grammars (lexer
and parser) to match the\r\nlatest version in
Elasticsearch.\r\n\r\nCo-authored-by: Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>","sha":"94120d9e40014fb82c82a1621321e12f65482e04","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL"],"title":"[ES|QL]
Update
grammars","number":194370,"url":"https://github.com/elastic/kibana/pull/194370","mergeCommit":{"message":"[ES|QL]
Update grammars (#194370)\n\nThis PR updates the ES|QL grammars (lexer
and parser) to match the\r\nlatest version in
Elasticsearch.\r\n\r\nCo-authored-by: Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>","sha":"94120d9e40014fb82c82a1621321e12f65482e04"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194370","number":194370,"mergeCommit":{"message":"[ES|QL]
Update grammars (#194370)\n\nThis PR updates the ES|QL grammars (lexer
and parser) to match the\r\nlatest version in
Elasticsearch.\r\n\r\nCo-authored-by: Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>","sha":"94120d9e40014fb82c82a1621321e12f65482e04"}}]}]
BACKPORT-->
angorayc pushed a commit to angorayc/kibana that referenced this pull request Oct 1, 2024
@kibanamachine @stratoula @angorayc
[ES|QL] Update grammars (elastic#194370)
c7f6edb 
This PR updates the ES|QL grammars (lexer and parser) to match the
latest version in Elasticsearch.

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
neptunian pushed a commit to neptunian/kibana that referenced this pull request Oct 1, 2024
@kibanamachine @neptunian
[8.x] [ES|QL] Update grammars (elastic#194370) (elastic#194378)
d5a91c9 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Update grammars
(elastic#194370)](elastic#194370)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kibana
Machine","email":"42973632+kibanamachine@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-30T07:39:17Z","message":"[ES|QL]
Update grammars (elastic#194370)\n\nThis PR updates the ES|QL grammars (lexer
and parser) to match the\r\nlatest version in
Elasticsearch.\r\n\r\nCo-authored-by: Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>","sha":"94120d9e40014fb82c82a1621321e12f65482e04","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL"],"title":"[ES|QL]
Update
grammars","number":194370,"url":"https://github.com/elastic/kibana/pull/194370","mergeCommit":{"message":"[ES|QL]
Update grammars (elastic#194370)\n\nThis PR updates the ES|QL grammars (lexer
and parser) to match the\r\nlatest version in
Elasticsearch.\r\n\r\nCo-authored-by: Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>","sha":"94120d9e40014fb82c82a1621321e12f65482e04"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194370","number":194370,"mergeCommit":{"message":"[ES|QL]
Update grammars (elastic#194370)\n\nThis PR updates the ES|QL grammars (lexer
and parser) to match the\r\nlatest version in
Elasticsearch.\r\n\r\nCo-authored-by: Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>","sha":"94120d9e40014fb82c82a1621321e12f65482e04"}}]}]
BACKPORT-->
seanrathier pushed a commit to seanrathier/kibana that referenced this pull request Oct 2, 2024
@kibanamachine @stratoula @seanrathier
[ES|QL] Update grammars (elastic#194370)
4a22741 
This PR updates the ES|QL grammars (lexer and parser) to match the
latest version in Elasticsearch.

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kibanamachine @elasticmachine @kibana-ci @stratoula