Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test #194043 #194670

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Fix flaky test #194043 #194670

merged 3 commits into from
Oct 2, 2024

Conversation

kertal
Copy link
Member

@kertal kertal commented Oct 2, 2024

Summary

Fix getRowIndicatorProvider should render log.level row indicators on Surrounding documents page flaky test error by waiting a bit longer for the table to be rendered. Let's hope it's not a :zombie flaky one 🤞

Fixes #194043

Flaky test suite (25): https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7060

Checklist

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7060

[✅] test/functional/apps/discover/context_awareness/config.ts: 25/25 tests passed.

see run history

@kertal kertal self-assigned this Oct 2, 2024
@kertal kertal added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) labels Oct 2, 2024
@kertal kertal marked this pull request as ready for review October 2, 2024 10:46
@kertal kertal requested a review from a team as a code owner October 2, 2024 10:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal changed the title Attempt to fix flaky test #194043 Fix flaky test #194043 Oct 2, 2024
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kertal kertal added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Oct 2, 2024
@kertal
Copy link
Member Author

kertal commented Oct 2, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #75 / discover/esql discover esql view ES|QL in Discover should render when switching to a time range with no data, then back to a time range with data

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@kertal kertal merged commit b7af143 into elastic:main Oct 2, 2024
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11145006142

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 194670

Questions ?

Please refer to the Backport tool documentation

@kertal
Copy link
Member Author

kertal commented Oct 2, 2024

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kertal added a commit to kertal/kibana that referenced this pull request Oct 2, 2024
Fixing `getRowIndicatorProvider should render log.level row indicators on Surrounding documents page` by waiting a bit longer for the table to be rendered.

(cherry picked from commit b7af143)

# Conflicts:
#	test/functional/apps/discover/context_awareness/extensions/_get_row_indicator_provider.ts
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v9.0.0
Projects
None yet
5 participants