Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alert details page] Update source and status bar #194842

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[Alert details page] Update source and status bar #194842

wants to merge 6 commits into from

Conversation

maryam-saeidi
Copy link
Member

@maryam-saeidi maryam-saeidi commented Oct 3, 2024 •
edited
Loading

Closes #187110
Closes #187111
Closes #153834

Summary

This PR changes how we show source and alert status information, as shown below:

image

Also, for the APM Latency rule type, we now have a threshold component similar to other rules. For the SLO burn rate rule, the SLO link is added to the source list.

Rule type Screenshot
APM Latency image
SLO burn rate image

@maryam-saeidi maryam-saeidi self-assigned this Oct 3, 2024
@maryam-saeidi maryam-saeidi added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 3, 2024
@maryam-saeidi maryam-saeidi marked this pull request as ready for review October 3, 2024 16:26
@maryam-saeidi maryam-saeidi requested review from a team as code owners October 3, 2024 16:26
@maryam-saeidi maryam-saeidi added the Team:obs-ux-management Observability Management User Experience Team label Oct 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Oct 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@maryam-saeidi maryam-saeidi added Feature:Alert Details Page Observability ux management team rca labels Oct 3, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1846 1848 +2
observability 1060 1061 +1
total +3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 703 702 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.4MB 3.4MB +624.0B
infra 1.6MB 1.6MB -24.0B
observability 467.1KB 467.4KB +332.0B
slo 855.4KB 855.4KB -11.0B
total +921.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
observability 22 23 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 102.7KB 103.7KB +1.1KB
Unknown metric groups

async chunk count

id before after diff
observability 19 20 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@kdelemme
Copy link
Contributor

kdelemme commented Oct 3, 2024

Not sure it's related to this PR, but the AI assistant panel is not separated from the source panel with the same space as the other panels:
image

kdelemme
kdelemme approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a question but otherwise lgtm. Tested locally and worked as expected.

...ns/observability_solution/observability/public/pages/alert_details/components/source_bar.tsx
Comment on lines +38 to +47
if (groups && groups.length > 0) {
alertSummary.push({
label: i18n.translate('xpack.observability.alertDetails.sourceBar.source', {
defaultMessage: 'Source',
}),
value: (
<Groups groups={groups} timeRange={alertEnd ? timeRange : { ...timeRange, to: 'now' }} />
),
});
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that used?

...ck/plugins/observability_solution/observability/public/pages/alert_details/alert_details.tsx
@@ -213,16 +214,16 @@ export function AlertDetails() {
isAlertDetailsEnabledPerApp(alertDetail.formatted, config) ? (
<>
<EuiSpacer size="l" />
<AlertSummary alert={alertDetail.formatted} alertSummaryFields={summaryFields} />
<SourceBar alert={alertDetail.formatted} sources={sources} />
<AlertDetailContextualInsights alert={alertDetail} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably need a spacer in between if the ai assistant is on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdelemme kdelemme kdelemme approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@maryam-saeidi maryam-saeidi

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project Feature:Alert Details Page Observability ux management team rca release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
5 participants
@maryam-saeidi @elasticmachine @kibana-ci @kdelemme @kibanamachine