[Onboarding] Make search_indices index details page as default route in index management #194857
Conversation
saarikabhasi
added
release_note:skip
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7076[✅] x-pack/test_serverless/api_integration/test_suites/search/common_configs/config.group1.ts: 25/25 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7077[✅] x-pack/test_serverless/api_integration/test_suites/search/common_configs/config.group1.ts: 25/25 tests passed. |
| renderRoute: () => { | ||
| return '/app/elasticsearch/indices/index_details/'; | ||
| }, | ||
| }); |
There was a problem hiding this comment.
I think we should take the index name and do the full template here. It would allow us to include a default tab.
| renderRoute: () => { | |
| return '/app/elasticsearch/indices/index_details/'; | |
| }, | |
| }); | |
| renderRoute: ({ indexName }) => { | |
| return `/app/elasticsearch/indices/index_details/${indexName}`; | |
| }, | |
| }); |
| const url = extensionsService.indexDetailsPageRoute.renderRoute({ index }); | ||
| application.navigateToUrl(`${url}${index.name}`); |
There was a problem hiding this comment.
| const url = extensionsService.indexDetailsPageRoute.renderRoute({ index }); | |
| application.navigateToUrl(`${url}${index.name}`); | |
| const url = extensionsService.indexDetailsPageRoute.renderRoute({ indexName: index.name }); | |
| application.navigateToUrl(url); |
| @@ -30,6 +30,9 @@ export interface IndexBadge { | |||
| filterExpression?: string; | |||
| color: EuiBadgeProps['color']; | |||
| } | |||
| export interface IndexDetailsPageRoute { | |||
| renderRoute: () => string; | |||
There was a problem hiding this comment.
In the usage this function is taking a variable. We should update this to have an accurate type.
| renderRoute: () => string; | |
| renderRoute: ({ indexName: string }) => string; |
….com:saarikabhasi/kibana into onboarding/make-search-indices-default-route
| history.push(getIndexDetailsLink(index.name, location.search || '')); | ||
| } else { | ||
| const route = extensionsService.indexDetailsPageRoute.renderRoute(index.name); | ||
| application.navigateToUrl(route); |
There was a problem hiding this comment.
This will work in serverless but in stateful I think you need to prepend the base path.
application.navigateToUrl(http.basePath.prepend(route));
we could do the http.basePath.prepend(route) in the renderRoute function too, we have coreStart available there.
There was a problem hiding this comment.
This will work in serverless but in stateful I think you need to prepend the base path.
Curious, why this wouldn't work in stateful ?
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
Makes
search_indicesindex details page as default route in the index_management plugin list page.index.management.details.page.mov
How to test:
kibana.dev.ymlas this plugin is behind Feature flagindex managementapp/app/elasticsearch/indices/index_details/my-index/dataxpack.searchIndices.enabled: falseinkibana.dev.ymlindex managementappChecklist
Delete any items that are not applicable to this PR.