Remove unused destroy function and killed variable

[stacey-gammon]

Yay for typescript, as it seems that client.close() is not a legit function, which lead me down a road to determine that this function isn't called at all, so killed is always true. I could be wrong, so I'll wait to check in with @kobelb before merging.

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[stacey-gammon]

Couple failures:

Server Mocha Tests.src/ui/ui_settings/create_or_upgrade_saved_config/__tests__/create_or_upgrade_integration·js.createOrUpgradeSavedConfig() "before all" hook
Server Mocha Tests.src/ui/ui_settings/create_or_upgrade_saved_config/__tests__/create_or_upgrade_integration·js.createOrUpgradeSavedConfig() "after all" hook

and

14:38:20    │ info  [ftr] exited with 0 after 2 minutes
14:38:50    │ warn  1 processes left running, stop them with procs.stop(name): [ 'kibana' ]
14:38:50    │ info  [kibana] exited with null after 3 minutes
14:38:50 Error: Proc "kibana" was stopped but never emitted either the "exit" or "error" event after 30000 ms

I've seen the second one before, I think it's just flaky. First one also looks unrelated.

jenkins, test this

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[stacey-gammon]

Failure on xpack tests:

15:41:12 
15:41:18  -> Running functional and api tests
15:41:27  info  Installing from source
15:41:27    │ info  source path: /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/elasticsearch
15:41:27    │ info  install path: /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/kibana/.es/test-8dw4zt6fq7j
15:41:27    │ info  license: trial
15:41:27    │ info  on master at 0522c6644d3743e634c20487600964073a972292
15:41:27    │ info  0 locally modified file(s)
15:41:27    │ info  ./gradlew :distribution:archives:tar:assemble
15:41:27    │ERROR  Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
15:41:45    │ERROR  Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
15:41:46    │ERROR  WARNING: An illegal reflective access operation has occurred
15:41:46    │ERROR  WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass (file:/var/lib/jenkins/.gradle/wrapper/dists/gradle-4.8.1-all/6fmj4nezasjg1b7kkmy10xgo2/gradle-4.8.1/lib/groovy-all-2.4.12.jar) to method java.lang.Object.finalize()
15:41:46    │ERROR  WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.CachedClass
15:41:46    │ERROR  WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
15:41:46    │ERROR  WARNING: All illegal access operations will be denied in a future release
15:41:52    │ERROR  Note: Some input files use unchecked or unsafe operations.
15:41:52    │ERROR  Note: Recompile with -Xlint:unchecked for details.
15:41:58    │ERROR  Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
15:42:08    │ERROR  WARNING: An illegal reflective access operation has occurred
15:42:08    │ERROR  WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass (file:/var/lib/jenkins/.gradle/wrapper/dists/gradle-4.8.1-all/6fmj4nezasjg1b7kkmy10xgo2/gradle-4.8.1/lib/groovy-all-2.4.12.jar) to method java.lang.Object.finalize()
15:42:08    │ERROR  WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.CachedClass
15:42:08    │ERROR  WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
15:42:08    │ERROR  WARNING: All illegal access operations will be denied in a future release
15:42:09    │ERROR  
15:42:09    │ERROR  14 tests completed, 1 failed
15:42:09    │ERROR  
15:42:09    │ERROR  FAILURE: Build failed with an exception.
15:42:09    │ERROR  
15:42:09    │ERROR  * What went wrong:
15:42:09    │ERROR  Execution failed for task ':buildSrc:test'.
15:42:09    │ERROR  > There were failing tests. See the report at: file:///var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/elasticsearch/buildSrc/build-bootstrap/reports/tests/test/index.html
15:42:09    │ERROR  
15:42:09    │ERROR  * Try:
15:42:09    │ERROR  Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
15:42:09    │ERROR  
15:42:09    │ERROR  * Get more help at https://help.gradle.org
15:42:09    │ERROR  
15:42:09    │ERROR  BUILD FAILED in 41s
15:42:09 Error: unable to build ES

jenkins, test this

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[stacey-gammon]

ping @kobelb

[nreese]

lgtm
code review. Looked for any calls to destroy method and could not find any.

[kobelb]

FWIW, I can't find any myself either. I think this is fine to remove it, we're killing the underlying process which will cause the evaluate calls to throw an error and break the loop.

[kobelb]

LGTM