Add clarification for server.ssl.supportedProtocols setting #22244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added clarification that the setting has to be an array. With the current wording you can assume that you can just add it as a simple string.
marius-dr
added
Team:Docs
Team:Security
💚 Build Succeeded |
|
Thanks for looking into this @marius-dr, that value does indeed have to be an array. My only concern is with the phrasing, if we say that the "values have to be an array" it makes me think that multiple things have to be arrays. What if instead we changed it to:
|
|
@kobelb that phrasing is better indeed. Changed it now. |
💚 Build Succeeded |
|
@marius-dr you mind backporting this as far back as we can without too many conflicts? |
This was referenced Aug 22, 2018
marius-dr
added a commit
to marius-dr/kibana
that referenced
this pull request
Aug 22, 2018
…22244) * Add clarification for server.ssl.supportedProtocols setting Added clarification that the setting has to be an array. With the current wording you can assume that you can just add it as a simple string. * Update settings.asciidoc
marius-dr
added a commit
to marius-dr/kibana
that referenced
this pull request
Aug 22, 2018
…22244) * Add clarification for server.ssl.supportedProtocols setting Added clarification that the setting has to be an array. With the current wording you can assume that you can just add it as a simple string. * Update settings.asciidoc
marius-dr
added a commit
that referenced
this pull request
Aug 23, 2018
…22265) * Add clarification for server.ssl.supportedProtocols setting Added clarification that the setting has to be an array. With the current wording you can assume that you can just add it as a simple string. * Update settings.asciidoc
marius-dr
added a commit
that referenced
this pull request
Aug 23, 2018
…22263) * Add clarification for server.ssl.supportedProtocols setting Added clarification that the setting has to be an array. With the current wording you can assume that you can just add it as a simple string. * Update settings.asciidoc
marius-dr
added a commit
that referenced
this pull request
Aug 24, 2018
…22264) * Add clarification for server.ssl.supportedProtocols setting Added clarification that the setting has to be an array. With the current wording you can assume that you can just add it as a simple string. * Update settings.asciidoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added clarification that the
server.ssl.supportedProtocolssetting has to be an array. With the current wording you can assume that you can set it as a simple string.@kobelb @legrego pinging you to confirm that the current behavior in Kibana in regards to this is the expected one. (if it's set as not an array it gives a fatal error:
FATAL { ValidationError: child "server" fails because [child "ssl" fails because [child "supportedProtocols" fails because ["supportedProtocols" must be an array]]])