-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates * characters to an escaped * #22269
Merged
jasonrhodes
merged 1 commit into
elastic:master
from
jasonrhodes:escape-asterisks-in-docs
Aug 22, 2018
Merged
Updates * characters to an escaped * #22269
jasonrhodes
merged 1 commit into
elastic:master
from
jasonrhodes:escape-asterisks-in-docs
Aug 22, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.
sorenlouv
approved these changes
Aug 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
jasonrhodes
added a commit
to jasonrhodes/kibana
that referenced
this pull request
Aug 22, 2018
GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.
jasonrhodes
added a commit
to jasonrhodes/kibana
that referenced
this pull request
Aug 22, 2018
GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.
💚 Build Succeeded |
graphaelli
pushed a commit
to graphaelli/kibana
that referenced
this pull request
Mar 5, 2019
GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.
bmorelli25
pushed a commit
to graphaelli/kibana
that referenced
this pull request
Mar 12, 2019
GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 15, 2019
GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine. # Conflicts: # docs/settings/apm-settings.asciidoc
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 15, 2019
GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine. # Conflicts: # docs/settings/apm-settings.asciidoc
This was referenced Mar 15, 2019
bmorelli25
added a commit
that referenced
this pull request
Mar 15, 2019
* fix spelling # Conflicts: # docs/settings/apm-settings.asciidoc * docs: add sentence on where to change apm settings (#27069) * [DOCS] Removes X-Pack settings section (#30554) Just the apm settings changes * Updates * characters to an escaped * (#22269) GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine. # Conflicts: # docs/settings/apm-settings.asciidoc * fix conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub's asciidoc parser handles
*
characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.Link: https://www.elastic.co/guide/en/kibana/master/apm-settings-kb.html