Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates * characters to an escaped * #22269

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

jasonrhodes
Copy link
Member

GitHub's asciidoc parser handles * characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.

Link: https://www.elastic.co/guide/en/kibana/master/apm-settings-kb.html

GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jasonrhodes jasonrhodes merged commit c7c3654 into elastic:master Aug 22, 2018
@jasonrhodes jasonrhodes deleted the escape-asterisks-in-docs branch August 22, 2018 19:20
jasonrhodes added a commit to jasonrhodes/kibana that referenced this pull request Aug 22, 2018
GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.
jasonrhodes added a commit to jasonrhodes/kibana that referenced this pull request Aug 22, 2018
GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

graphaelli pushed a commit to graphaelli/kibana that referenced this pull request Mar 5, 2019
GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.
bmorelli25 pushed a commit to graphaelli/kibana that referenced this pull request Mar 12, 2019
GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 15, 2019
GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.

# Conflicts:
#	docs/settings/apm-settings.asciidoc
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 15, 2019
GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.

# Conflicts:
#	docs/settings/apm-settings.asciidoc
bmorelli25 added a commit that referenced this pull request Mar 15, 2019
* fix spelling

# Conflicts:
#	docs/settings/apm-settings.asciidoc

* docs: add sentence on where to change apm settings (#27069)

* [DOCS] Removes X-Pack settings section (#30554)

Just the apm settings changes

* Updates * characters to an escaped * (#22269)

GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.

# Conflicts:
#	docs/settings/apm-settings.asciidoc

* fix conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants