Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Fix possible flakiness of saveVisualization action (#22356) #22546

Merged
merged 1 commit into from
Sep 3, 2018
Merged

[6.x] Fix possible flakiness of saveVisualization action (#22356) #22546

merged 1 commit into from
Sep 3, 2018

Conversation

markov00
Copy link
Member

Backports the following commits to 6.x:

@markov00
Fix possible flakiness of saveVisualization action (elastic#22356)
d0a039c 
* Updated saveVisualization to wait for toast instead of global indicator

* Fix RBAC tests.

The saveVisualization now fails directly if the visualization is not correctly saved.

* Change editor to use toast for errors

* Change saveVisualization method to new saveVisualizationExpectSuccess

For RBAC tests used also saveVisualizationExpectFail

* Fix wrong exists method call

* Fix missing exist function
@elasticmachine
Copy link
Contributor

💔 Build Failed

@markov00
Copy link
Member Author 

38:56    │ warn Failure loading service "remote"
17:38:56    │ERROR [POST http://localhost:9515/session / {"desiredCapabilities":{},"requiredCapabilities":{}}] unknown error: Chrome failed to start: exited abnormally
17:38:56    │        (unknown error: DevToolsActivePort file doesn't exist)
17:38:56    │        (The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)
17:38:56    │        (Driver info: chromedriver=2.41.578700 (2f1ed5f9343c13f73144538f15c00b370eda6706),platform=Linux 4.9.0-8-amd64 x86_64)
17:38:56    │          at Server._post (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/kibana/test/functional/services/remote/verbose_remote_logging.js:34:21)
17:38:56    │          at Server.createSession (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/kibana/node_modules/leadfoot/Server.js:362:15)
17:38:56    │          at attemptToCreateCommand (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/kibana/test/functional/services/remote/leadfoot_command.js:38:32)
17:38:56    │          at Promise.race (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/kibana/test/functional/services/remote/leadfoot_command.js:86:11)
17:38:56    │          at initLeadfootCommand (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/kibana/test/functional/services/remote/leadfoot_command.js:63:5)
17:38:56    │          at RemoteProvider (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/kibana/test/functional/services/remote/remote.js:40:29)
17:38:56    │          at <anonymous>
17:38:56    │ warn 1 processes left running, stop them with procs.stop(name): [ 'kibana' ]
17:38:56    │ info [kibana] exited with null after a minute
17:38:56 
17:38:56 Failure initializing 1 service(s)
17:38:56     at ProviderCollection.loadAll (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/kibana/src/functional_test_runner/lib/providers/provider_collection.js:71:13)
17:38:56     at <anonymous>
17:38:56     at process._tickCallback (internal/process/next_tick.js:188:7)

jenkins test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@markov00
Copy link
Member Author

markov00 commented Sep 3, 2018

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@markov00
Copy link
Member Author

markov00 commented Sep 3, 2018

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@markov00 markov00 merged commit 6b504ed into elastic:6.x Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markov00 @elasticmachine