-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations for Reporting plugin #22757
Changes from 10 commits
389e495
5c6974f
3fc0d30
730d0c4
6e76e77
b8b8fb0
4f1652b
aa52270
abf7349
f6092ab
3e98293
eb9b0a5
8b01dfa
7fb96b2
9b052de
41e728a
2d00e85
0ac7fed
6e11f48
91ffb59
75176e8
7aa16a8
086a230
ae80880
0f13af5
b529dda
736972b
4712291
3bb3ff0
9c5b975
ae9f396
063d9ea
8659300
b5ff8dd
434f836
3e4fc04
f0feceb
9e6d950
8eb3831
6d002d2
d1e3ed9
400f252
456ac17
cec501e
e83852e
525acfb
d3a5150
771fdd0
2079139
a6f2cf4
a725450
ba061e7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
<div class="pdf-options"> | ||
<label> | ||
<input type="radio" ng-model="options.layoutId" value="print"> | ||
Optimize PDF for printing | ||
<span i18n-id="xpack.reporting.exportTypes.printablePdf.options.optimizeLabel" i18n-default-message="Optimize PDF for printing"></span> | ||
</label> | ||
<label data-test-subj="preserveLayoutOption"> | ||
<input type="radio" ng-model="options.layoutId" value="preserve_layout"> | ||
Preserve existing layout in PDF | ||
<span i18n-id="xpack.reporting.exportTypes.printablePdf.options.preserveLayoutLabel" i18n-default-message="Preserve existing layout in PDF"></span> | ||
</label> | ||
</div> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,15 +8,15 @@ import 'plugins/reporting/directives/export_config'; | |
import { XPackInfoProvider } from 'plugins/xpack_main/services/xpack_info'; | ||
import { NavBarExtensionsRegistryProvider } from 'ui/registry/navbar_extensions'; | ||
|
||
function discoverReportProvider(Private) { | ||
function discoverReportProvider(Private, i18n) { | ||
const xpackInfo = Private(XPackInfoProvider); | ||
return { | ||
appName: 'discover', | ||
|
||
key: 'reporting-discover', | ||
label: 'Reporting', | ||
label: i18n('xpack.reporting.controls.discover.reportingTitle', { defaultMessage: 'Reporting' }), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reportingTitle => reportingLabel |
||
template: '<export-config object-type="Search" enabled-export-type="csv"></export-config>', | ||
description: 'Search Report', | ||
description: i18n('xpack.reporting.controls.discover.searchReportAriaLabel', { defaultMessage: 'Search Report' }), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. searchReportAriaLabel => reportingDescription |
||
hideButton: () => !xpackInfo.get('features.reporting.csv.showLinks', false), | ||
disableButton: () => !xpackInfo.get('features.reporting.csv.enableLinks', false), | ||
tooltip: () => xpackInfo.get('features.reporting.csv.message'), | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,20 +9,20 @@ import { XPackInfoProvider } from 'plugins/xpack_main/services/xpack_info'; | |
import { NavBarExtensionsRegistryProvider } from 'ui/registry/navbar_extensions'; | ||
import { VisualizeConstants } from 'plugins/kibana/visualize/visualize_constants'; | ||
|
||
function visualizeReportProvider(Private, $location) { | ||
function visualizeReportProvider(Private, $location, i18n) { | ||
const xpackInfo = Private(XPackInfoProvider); | ||
return { | ||
appName: 'visualize', | ||
|
||
key: 'reporting-visualize', | ||
label: 'Reporting', | ||
label: i18n('xpack.reporting.controls.visualize.reportingTitle', { defaultMessage: 'Reporting' }), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reportingTitle => reportingLabel |
||
template: ` | ||
<export-config | ||
object-type="Visualization" | ||
enabled-export-type="printablePdf" | ||
options="{ layoutId: 'preserve_layout' }" | ||
></export-config>`, | ||
description: 'Visualization Report', | ||
description: i18n('xpack.reporting.controls.visualize.reportAriaLabel', { defaultMessage: 'Visualization Report' }), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reportAriaLabel => reportingDescription |
||
hideButton: () => ( | ||
$location.path() === VisualizeConstants.LANDING_PAGE_PATH | ||
|| $location.path() === VisualizeConstants.WIZARD_STEP_1_PAGE_PATH | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,6 @@ | ||
<div ng-show="!exportConfig.isDirty()"> | ||
<div class="kuiLocalDropdownSection"> | ||
<h2 class="kuiLocalDropdownTitle"> | ||
Reporting | ||
</h2> | ||
<h2 class="kuiLocalDropdownTitle" i18n-id="xpack.reporting.exportConfig.reportingTitle" i18n-default-message="Reporting"></h2> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's break this line up per attribute, for consistency |
||
|
||
<div class="input-group generate-controls"> | ||
<div class="options"></div> | ||
|
@@ -11,7 +9,9 @@ <h2 class="kuiLocalDropdownTitle"> | |
data-test-subj="generateReportButton" | ||
ng-click="exportConfig.export()" | ||
> | ||
Generate {{ exportConfig.exportType.name }} | ||
<span i18n-id="xpack.reporting.exportConfig.generateButtonLabel" | ||
i18n-default-message="Generate {name}" | ||
i18n-values="{ name: exportConfig.exportType.name }"></span> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Formatting and indentation looks messed up here. Should be like:
|
||
</button> | ||
</div> | ||
</div> | ||
|
@@ -23,16 +23,18 @@ <h2 class="kuiLocalDropdownTitle"> | |
<label | ||
class="kuiLocalDropdownHeader__label" | ||
for="reportGenerationUrl" | ||
i18n-id="xpack.reporting.exportConfig.generationUrl.label" | ||
i18n-default-message="Generation URL" | ||
> | ||
Generation URL | ||
</label> | ||
<div class="kuiLocalDropdownHeader__actions"> | ||
<a | ||
class="kuiLocalDropdownHeader__action" | ||
ng-click="exportConfig.copyToClipboard('#reportGenerationUrl')" | ||
kbn-accessible-click | ||
i18n-id="xpack.reporting.exportConfig.generationUrl.copyLinkLabel" | ||
i18n-default-message="Copy" | ||
> | ||
Copy | ||
</a> | ||
</div> | ||
</div> | ||
|
@@ -44,12 +46,13 @@ <h2 class="kuiLocalDropdownTitle"> | |
type="text" | ||
readonly | ||
data-test-subj="reportGenerationUrl" | ||
value="{{ exportConfig.absoluteUrl || 'Loading...' }}" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we do not need "|| 'Loading...'" anymore? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, I see you moved it to another place There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. But anyway I'm not sure that this is a good idea to put 'loading...' to absoluteUrl property because 'loading...' is not url and if we want to use this property somewhere else we will expect it contains url, not 'loading...'. |
||
value="{{ exportConfig.absoluteUrl }}" | ||
ng-click="updateUrl()" | ||
/> | ||
</div> | ||
</div> | ||
|
||
<div ng-show="exportConfig.isDirty()" data-test-subj="unsavedChangesReportingWarning"> | ||
Please save your work before generating a report. | ||
<div ng-show="exportConfig.isDirty()" data-test-subj="unsavedChangesReportingWarning" | ||
i18n-id="xpack.reporting.exportConfig.saveWorkDescription" | ||
i18n-default-message="Please save your work before generating a report."> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currentString => currentPage