Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[I18n] Update locale objects format #23917

Merged
merged 13 commits into from
Oct 26, 2018
Merged

[I18n] Update locale objects format #23917

merged 13 commits into from
Oct 26, 2018

Conversation

LeanidShutau
Copy link
Contributor

@LeanidShutau LeanidShutau commented Oct 9, 2018 •
edited
Loading

Resolves #23526

@LeanidShutau LeanidShutau added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Project:i18n v6.5.0 labels Oct 9, 2018
@LeanidShutau LeanidShutau self-assigned this Oct 9, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@LeanidShutau LeanidShutau force-pushed the feature/i18n-update-locale-object-format branch from e61f32c to 26eb6b6 Compare October 9, 2018 14:20
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

maryia-lapata
maryia-lapata approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I checked with pseudo locale.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@LeanidShutau
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@LeanidShutau
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

azasypkin
azasypkin requested changes Oct 16, 2018
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a proposal, since you're here, let's finally improve that part of the lib and make it more obvious.

packages/kbn-i18n/src/messages.ts Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@LeanidShutau LeanidShutau requested review from azasypkin and removed request for pavel06081991 October 18, 2018 14:19
@azasypkin
Copy link
Member

@LeanidShutau please merge master into this PR to resolve conflicts

azasypkin
azasypkin requested changes Oct 23, 2018
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but requires a couple more changes.

packages/kbn-i18n/src/core/i18n.ts Outdated Show resolved Hide resolved
packages/kbn-i18n/src/core/i18n.ts Outdated Show resolved Hide resolved
packages/kbn-i18n/src/core/i18n.ts Show resolved Hide resolved
packages/kbn-i18n/src/core/i18n.ts Outdated Show resolved Hide resolved
packages/kbn-i18n/src/core/i18n.ts Outdated Show resolved Hide resolved
packages/kbn-i18n/src/angular/provider.ts Outdated Show resolved Hide resolved
packages/kbn-i18n/src/loader.ts Outdated Show resolved Hide resolved
packages/kbn-i18n/src/loader.ts Outdated Show resolved Hide resolved
packages/kbn-i18n/src/react/provider.tsx Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

azasypkin
azasypkin approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one last nit.

packages/kbn-i18n/src/loader.ts Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@LeanidShutau LeanidShutau merged commit 074556f into elastic:master Oct 26, 2018
@LeanidShutau LeanidShutau deleted the feature/i18n-update-locale-object-format branch October 26, 2018 10:36
LeanidShutau added a commit to LeanidShutau/kibana that referenced this pull request Oct 26, 2018
@LeanidShutau
[I18n] Update locale objects format (elastic#23917)
4ab2bd2 
* Update output file format for i18n_check tool

* Update i18n engine to work with new format

* Update tests

* Fix UI bootstrap test

* Update loader tests and fix getTranslationsByLocale function

* Fix messages passing to IntlProvider

* Update messages interface

* Resolve comments

* Resolve comment
@LeanidShutau LeanidShutau mentioned this pull request Oct 26, 2018
Merged
LeanidShutau added a commit to LeanidShutau/kibana that referenced this pull request Oct 29, 2018
@LeanidShutau
[I18n] Update locale objects format (elastic#23917)
dc8f248 
* Update output file format for i18n_check tool

* Update i18n engine to work with new format

* Update tests

* Fix UI bootstrap test

* Update loader tests and fix getTranslationsByLocale function

* Fix messages passing to IntlProvider

* Update messages interface

* Resolve comments

* Resolve comment
LeanidShutau added a commit that referenced this pull request Oct 29, 2018
@LeanidShutau
[I18n] Update locale objects format (#23917) (#24639)
b3086f2 
* Update output file format for i18n_check tool

* Update i18n engine to work with new format

* Update tests

* Fix UI bootstrap test

* Update loader tests and fix getTranslationsByLocale function

* Fix messages passing to IntlProvider

* Update messages interface

* Resolve comments

* Resolve comment
@LeanidShutau
Copy link
Contributor Author

6.x/6.6: b3086f2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

@maryia-lapata maryia-lapata maryia-lapata approved these changes

Assignees

@LeanidShutau LeanidShutau

Labels
backported Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LeanidShutau @elasticmachine @azasypkin @maryia-lapata