-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump hacky timeout and re-enable Reporting tests #24109
Bump hacky timeout and re-enable Reporting tests #24109
Conversation
💚 Build Succeeded |
retest |
💔 Build Failed |
x-pack passed, selenium OSS failed:
So reporting tests still good. jenkins, test this |
💔 Build Failed |
Friggin A. Report failure, though not because of a report discrepency:
No captured report to view. |
This code used to be in a retry loop because of some error being hit. This retry loop was removed in https://github.com/elastic/kibana/pull/21788/files. I think Chris just stopped hitting it so got rid of it. Now it appears to be back though, so I think it needs to go back in there. Ah, I remember now. The retry logic had some issues, like hiding legit issues when the page counts didn't match up. It was removed, and appeared like it was not needed because the tests passed for awhile in a row. Now it's hit again. I'll bring back the retry but not the original issues with the first implementation. |
💔 Build Failed |
997eb93
to
71c7af1
Compare
💚 Build Succeeded |
retest |
💔 Build Failed |
OH reporting. Forget it @tsullivan on the review, need to iterate. Hitting "failed to convert page to image" errors, even with the retry.
Failed on
Top failure was:
Passed on:
Passed on:
|
Given the above list of agents it passed on vs hit that "failed to convert page to image" bug, and since the retry didn't work, I wonder if some agents are missing dependencies. Filed jenkins, test this |
💚 Build SucceededNode is kibana-ci-immutable-centos-1539823670287899100 - consistent with above theory |
retest |
💔 Build Failedand another failure on
|
Infra ticket has been closed. jenkins, test this |
💚 Build Succeededflyweight kibana-ci-immutable-flyweight-1539969431488370994 swarm |
retest |
💔 Build Failed |
Failed on the existing jenkins, test this |
💔 Build Failed |
Failed on:
|
71c7af1
to
ea75b71
Compare
retest |
1 similar comment
retest |
💔 Build Failed |
💚 Build Succeeded |
retest |
💔 Build Failed |
😭 still failed on the
because of "failed to convert page to image". The infra ticket getting resolved must not have helped. more stack trace info:
|
retest |
💔 Build Failed |
Now failed on:
|
Another path I may follow, after reading http://imagemagick.org/discourse-server/viewtopic.php?t=19218 remove the |
💚 Build Succeeded |
above was centos, so still not sure it worked. jenkins, test this |
💔 Build Failed |
Well, something different this time at least:
screenshots in the job, will post later |
I think the above might actually be hitting: #22730 |
I'd love to jump in on this and see if I can't help get this over the line :) |
That'd be great @joelgriffith, it's all yours! We recently checked in some documentation around reporting testing, so this can help get you started in that environment: https://github.com/elastic/kibana/blob/master/x-pack/test/reporting/README.md |
Try to "fix" #22581 and re-enable the reporting tests.
Bumps hacky fix timeout from 100 to 250ms. Background is that when Chromium was using an older version, it was slower to load, and it hid a legit bug. Chromium loads the page faster now (or at least the current implementation loads the page faster - maybe puppeteer vs chrome-remote-interface), the first visualization may fail to render in time. We set up a timeout to fake the slower load. It sucks, but for the time being, until we can spend more time focusing on a legit fix, it is what it is.
uiSettings.replace was overwriting the disableAnimations setting which helps a ton with flakiness
"Failed to convert page to image" is still a legit issue, so the retry was re-inserted (in a better implementation this time around)
Update jenkins agents to have all dependencies installed for the pdf/png testing libraries. (https://github.com/elastic/infra/issues/7418)