Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Move mustache typings to devDependencies (#24165) #24215

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

weltenwort
Copy link
Member

Backports the following commits to 6.x:

This moves the `@types/mustache` package from `dependencies` to `devDependencies` to avoid unnecessary inclusion in the build artifacts.
@weltenwort weltenwort self-assigned this Oct 18, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@weltenwort
Copy link
Member Author

00:31:01.512              └- ✖ fail: "dashboard app using current data dashboard data-shared attributes data-shared-item title should update a saved search when using a custom panel title"
00:31:01.512              │      retry.try timeout: Error: retry.try timeout: Error: retry.try timeout: [POST http://localhost:9515/session/69caa62e37a9e0c57e171590926ed03e/element / {"using":"css selector","value":"[data-test-subj~=\"customDashboardPanelTitleInput\"]"}] no such element: Unable to locate element: {"method":"css selector","selector":"[data-test-subj~="customDashboardPanelTitleInput"]"}
00:31:01.515              │   (Session info: chrome=70.0.3538.67)
00:31:01.515              │   (Driver info: chromedriver=2.42.591071 (0b695ff80972cc1a65a5cd643186d2ae582cd4ac),platform=Linux 3.10.0-862.14.4.el7.x86_64 x86_64)

maybe flakey dashboard test... jenkins, test this again

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@weltenwort weltenwort merged commit caefd65 into elastic:6.x Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants