Canvas saved objects for sample data #24347

nreese · 2018-10-22T17:11:33Z

Adds canvas saved objects for #22893, #22892, and #22891
cc @alexfrancoeur

alexfrancoeur · 2018-10-22T17:24:57Z

@nreese - all looks good to me here with one small exception. Not sure how this happened and it could have gotten lost in transition but OS and RAM are meant to be on two lines

Any chance you could tweak the expression for that object so that the results looks like this?

Expression can be copy and pasted below:

filters
| esdocs index="kibana_sample_data_logs" sort="timestamp, desc" fields="machine.os, machine.ram" count=1
| markdown "**OS:** " {getCell "machine.os"} "\
 **RAM:** " {getCell "machine.ram" | formatNumber "00.0b"}
font={font family="'Open Sans', Helvetica, Arial, sans-serif" size=20 align="left" color="#FFFFFF" weight="lighter" underline=false italic=false}
| render containerStyle={containerStyle padding="5px"}

alexfrancoeur · 2018-10-22T17:37:11Z

Works fine with Spaces (with the exception of known issues for Canvas/Spaces). I did run into an issue removing it from a Space though. After removing it, and loading up Canvas I saw the below error. Refreshing Canvas showed me an empty landing page.

I was able to reproduce this multiple times.

Add web logs sample data
load up canvas workpad
leave canvas and remove web logs
return to canvas
see error
refresh
no more error

nreese · 2018-10-22T19:37:57Z

jenkins, test this

nreese · 2018-10-22T23:01:12Z

jenkins, test this

elasticmachine · 2018-10-22T23:10:57Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-23T00:39:47Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-23T02:55:28Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

nreese · 2018-10-23T12:27:45Z

jenkins, test this

… build problems

elasticmachine · 2018-10-23T15:30:14Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…anvas

elasticmachine · 2018-10-23T16:19:52Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-23T16:25:32Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

nreese · 2018-10-23T16:28:53Z

jenkins, test this

cqliu1

LGTM 👍

I noticed that the "Updated" date keeps the original date in the saved object JSON instead of setting it to the current datetime. I'd expect to see the sample workpads at the top, but that's not necessarily the case if you already have existing workpads. That's a change we'll make on the Canvas side. No changes required from you.

nreese · 2018-10-23T17:52:26Z

@cqliu1 Should I just remove the updated_at field from the saved object so its give a new value anytime it is installed?

cqliu1 · 2018-10-23T18:05:02Z

No that's not necessary. We just need to override that date on upload on the Canvas side. It doesn't matter if you remove or not.

cqliu1 · 2018-10-23T18:20:45Z

@nreese Actually I was wrong... Would it possible for you to update the date on that saved object before you store it? Since you're hitting the saved objects API directly, it won't go through our upload handler and that "Updated" date should be set to the new date before it's stored.

elasticmachine · 2018-10-23T18:53:24Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…t top of list when sorted by date

cqliu1

LGTM 👍 Thanks for updating the timestamps.

elasticmachine · 2018-10-23T20:41:47Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

alexfrancoeur · 2018-10-23T21:03:13Z

…

On Tue, Oct 23, 2018 at 4:42 PM Elastic Machine ***@***.***> wrote: 💚 Build Succeeded - continuous-integration/kibana-ci/pull-request <https://kibana-ci.elastic.co/job/elastic-kibana-pull-request/6097/> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24347 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYA-fzN07zzqUp39vGt2GXik2BtDFgE7ks5un38fgaJpZM4Xzx6t> .

elasticmachine · 2018-10-23T21:38:07Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* Canvas saved objects for sample data * fix line break in MACHINE element * store canvas saved objects in json files instead of js files to avoid build problems * remove logging statement * set canvas-workpad timestamps to current time so they are displayed at top of list when sorted by date

alexfrancoeur · 2018-10-23T23:24:45Z

yessss @nreese!!! Thank you so much, I really appreciate you adding this in last minute. I really feel like it will help with Canvas adoption. Appreciate you and @cqliu1 for the last minute PR for 6.5

* Canvas saved objects for sample data * fix line break in MACHINE element * store canvas saved objects in json files instead of js files to avoid build problems * remove logging statement * set canvas-workpad timestamps to current time so they are displayed at top of list when sorted by date

Canvas saved objects for sample data

3ba5e8f

nreese added v7.0.0 v6.5.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 22, 2018

fix line break in MACHINE element

414d7a1

alexfrancoeur mentioned this pull request Oct 22, 2018

Feat: Workpad Templates #23966

Merged

nreese mentioned this pull request Oct 22, 2018

If you delete sample data from one space, it breaks sample visualizations in other spaces #24263

Open

nreese requested a review from cqliu1 October 23, 2018 00:13

store canvas saved objects in json files instead of js files to avoid…

6d4a161

… build problems

nreese added 2 commits October 23, 2018 09:41

Merge branch 'master' of github.com:elastic/kibana into sample_data_c…

7cb5c22

…anvas

remove logging statement

9cd409b

cqliu1 approved these changes Oct 23, 2018

View reviewed changes

cqliu1 closed this Oct 23, 2018

cqliu1 reopened this Oct 23, 2018

set canvas-workpad timestamps to current time so they are displayed a…

2234736

…t top of list when sorted by date

cqliu1 self-requested a review October 23, 2018 19:28

cqliu1 approved these changes Oct 23, 2018

View reviewed changes

nreese merged commit 60bb498 into elastic:master Oct 23, 2018

nreese mentioned this pull request Oct 23, 2018

[6.x] Canvas saved objects for sample data (#24347) #24449

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Canvas saved objects for sample data #24347

Canvas saved objects for sample data #24347

nreese commented Oct 22, 2018 •

edited

Loading

alexfrancoeur commented Oct 22, 2018

alexfrancoeur commented Oct 22, 2018

nreese commented Oct 22, 2018

nreese commented Oct 22, 2018

elasticmachine commented Oct 22, 2018

elasticmachine commented Oct 23, 2018

elasticmachine commented Oct 23, 2018

nreese commented Oct 23, 2018

elasticmachine commented Oct 23, 2018

elasticmachine commented Oct 23, 2018

elasticmachine commented Oct 23, 2018

nreese commented Oct 23, 2018

cqliu1 left a comment •

edited

Loading

nreese commented Oct 23, 2018

cqliu1 commented Oct 23, 2018

cqliu1 commented Oct 23, 2018

elasticmachine commented Oct 23, 2018

cqliu1 left a comment

elasticmachine commented Oct 23, 2018

alexfrancoeur commented Oct 23, 2018 via email

elasticmachine commented Oct 23, 2018

alexfrancoeur commented Oct 23, 2018

Canvas saved objects for sample data #24347

Canvas saved objects for sample data #24347

Conversation

nreese commented Oct 22, 2018 • edited Loading

alexfrancoeur commented Oct 22, 2018

alexfrancoeur commented Oct 22, 2018

nreese commented Oct 22, 2018

nreese commented Oct 22, 2018

elasticmachine commented Oct 22, 2018

💔 Build Failed

elasticmachine commented Oct 23, 2018

💔 Build Failed

elasticmachine commented Oct 23, 2018

💔 Build Failed

nreese commented Oct 23, 2018

elasticmachine commented Oct 23, 2018

💔 Build Failed

elasticmachine commented Oct 23, 2018

💔 Build Failed

elasticmachine commented Oct 23, 2018

💔 Build Failed

nreese commented Oct 23, 2018

cqliu1 left a comment • edited Loading

Choose a reason for hiding this comment

nreese commented Oct 23, 2018

cqliu1 commented Oct 23, 2018

cqliu1 commented Oct 23, 2018

elasticmachine commented Oct 23, 2018

💚 Build Succeeded

cqliu1 left a comment

Choose a reason for hiding this comment

elasticmachine commented Oct 23, 2018

💚 Build Succeeded

alexfrancoeur commented Oct 23, 2018 via email

elasticmachine commented Oct 23, 2018

💚 Build Succeeded

alexfrancoeur commented Oct 23, 2018

nreese commented Oct 22, 2018 •

edited

Loading

cqliu1 left a comment •

edited

Loading