Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] [ML] Fix a call stack size exception triggered by a negative tickInterval. (#24742) #24815

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

walterra
Copy link
Contributor

Backports the following commits to 6.x:

…rval. (elastic#24742)

In certain cases tickInterval mistakenly could end up being negative which made getTickValues() run into a call stack size exception. This PR fixes it by a) adding a check to getTickValues() that interval must not be 0 or smaller and b) changing the way the tickInterval is determined in the Anomaly Explorer Charts.
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@walterra walterra added the :ml label Oct 30, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@walterra walterra merged commit a302580 into elastic:6.x Oct 30, 2018
@walterra walterra deleted the backport/6.x/pr-24742 branch October 30, 2018 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants