Order terms on metric #2515
Merged
Order terms on metric #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
orderTermsOnMetric
branch
from
e495470
to
33f4bbc
Compare
spalger
force-pushed
the
orderTermsOnMetric
branch
from
860c4d3
to
f62db8a
Compare
…so that AggParams is more reusable
spalger
force-pushed
the
orderTermsOnMetric
branch
from
f62db8a
to
9255c3d
Compare
|
I <3 this. Styling could use some <3, but not a blocker. Maybe something like this?
Needs a merge with master and a 2nd set of eyes on the code. Also, looks like tests were updated but no new tests for the added code? |
added 3 commits
January 6, 2015 09:25
… orderTermsOnMetric Conflicts: src/kibana/plugins/visualize/editor/agg.js
…w33ble's new editor ecosystem
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to order a terms agg by a custom metric aggregation. Includes #2514