Changes APM home page to use route-based tabs #25891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tabs to component with tests
💔 Build Failed |
💔 Build Failed |
ogupte
approved these changes
Nov 20, 2018
💚 Build Succeeded |
jasonrhodes
commented
Nov 20, 2018
| @@ -94,3 +114,18 @@ export const routes = [ | |||
| legacyDecodeURIComponent(match.params.transactionName) | |||
| } | |||
| ]; | |||
| // { | |||
There was a problem hiding this comment.
Remove commented code
💔 Build Failed |
|
retest |
💚 Build Succeeded |
jasonrhodes
added a commit
to jasonrhodes/kibana
that referenced
this pull request
Nov 21, 2018
* Changed home page to use route based history tabs, abstracted history tabs to component with tests * Spreads location on tab links to preserve query string etc * Adds ts-ignore to 'fix' problem with TS not finding EuiTab and EuiTabs modules in EUI exports * Fixes breadcrumbs and service redirect * Removes commented code
jasonrhodes
added a commit
that referenced
this pull request
Nov 25, 2018
* Changed home page to use route based history tabs, abstracted history tabs to component with tests * Spreads location on tab links to preserve query string etc * Adds ts-ignore to 'fix' problem with TS not finding EuiTab and EuiTabs modules in EUI exports * Fixes breadcrumbs and service redirect * Removes commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23824
Summary
To make new routes for the /services and /traces tabs that are navigable via browser address, I used React Router's
<Route>component nested inside the<Home>route. I moved this type of Tabbed Content out to a new component calledHistoryTabs, which are now reusable anywhere else we'd like to use this pattern (with a prerequisite that all the top-level paths have to point to the single component where the history tabs live).Also adds a test, and a redirect from / -> /services via the route config file.
To Do: