Handle deprecated SSL config settings. #26196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
bug
💚 Build Succeeded |
epixa
approved these changes
Nov 26, 2018
epixa
added
release_note:fix
and removed
bug
This was referenced Nov 26, 2018
azasypkin
added a commit
to azasypkin/kibana
that referenced
this pull request
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #21956 new platform started to parse config earlier than the legacy one and hence we stopped to handle two SSL config deprecation cases:
server.ssl.certtoserver.ssl.certificateserver.ssl.enabledtotrueifserver.ssl.certificateandserver.ssl.keyare presentedThere is one more deprecation case that is only related to the new platform, but doesn't need to be handled in this PR since it only leads to the warning and doesn't transform config:
server.rewriteBasePathIn this PR I just transform legacy SSL config consumed by the new platform in accordance with deprecation transformation, but leave warnings to the legacy platform (it receives original config and hence issues correct warnings). It seems to be the safest and easiest solution and this code will be dropped in 7.0 anyway. Later on we should think through and implement proper deprecation handling system in the new platform itself.
What do you think @epixa @elastic/kibana-platform ?