Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ILM privileges #27461

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Add ILM privileges #27461

merged 1 commit into from
Dec 20, 2018

Conversation

talevy
Copy link
Contributor

@talevy talevy commented Dec 19, 2018

This commit adds the manage_ilm, read_ilm cluster
privileges, and the manage_ilm index privilege.

these were introduced into ES by:
elastic/elasticsearch#36493

This commit adds the `manage_ilm`, `read_ilm` cluster
privileges, and the `manage_ilm` index privilege.

these were introduced into ES by:
elastic/elasticsearch#36493
@talevy talevy requested a review from a team as a code owner December 19, 2018 00:44
@talevy talevy added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Dec 19, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested locally. Thanks for taking the time to submit this, @talevy!

@talevy
Copy link
Contributor Author

talevy commented Dec 19, 2018

thanks for testing locally @legrego! Since the 6.6 branch was just cut, do you think this is
something that is appropriate to merge into that branch pre-release? These roles are
available in Elasticsearch 6.6.

Let me know what you think, thanks!

@legrego
Copy link
Member

legrego commented Dec 19, 2018

I think it'd be great to include it for 6.6, but I'm not sure who makes that call... @stacey-gammon are you the release manager for 6.6?

@stacey-gammon
Copy link
Contributor

nope, just 6.5.4, but, I'd say it probably shouldn't go in unless it's a blocker.

@talevy
Copy link
Contributor Author

talevy commented Dec 19, 2018

OK, I'll merge into 6.x and master soon. thank you all

@talevy talevy merged commit 88aa143 into elastic:master Dec 20, 2018
@talevy talevy deleted the ilm-priv branch December 20, 2018 16:53
talevy added a commit that referenced this pull request Dec 20, 2018
This commit adds the `manage_ilm`, `read_ilm` cluster
privileges, and the `manage_ilm` index privilege.

these were introduced into ES by:
elastic/elasticsearch#36493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v6.6.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants