Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed eventBus completely, fix field list auto complete #286

Merged
merged 1 commit into from
Jul 27, 2013

Conversation

rashidkpc
Copy link
Contributor

No description provided.

rashidkpc pushed a commit that referenced this pull request Jul 27, 2013
removed eventBus completely, fix field list auto complete
@rashidkpc rashidkpc merged commit f329fca into elastic:master Jul 27, 2013
harper-carroll pushed a commit to harper-carroll/kibana that referenced this pull request Jul 11, 2016
Adding new field for tcp established.
w33ble added a commit to w33ble/kibana that referenced this pull request Sep 13, 2018
* chore: replace gulp-util, it is deprecated

see https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5

* chore: fix eslint config extends priority

* chore: update the eslint dependencies

* chore: fix lint-fix task

return the stream so it completes, and fail the task if there are unresolved errors

* chore: tweak eslint config, add config for paths

override some rules, and set env for specific paths

* chore: bump gulp-eslint

* chore: fix code issues caught by linter

these were all the issue found after running the eslint auto-fix

* chore: eslint auto-fix, with hand edits

manually reviewed all changes, hand edited some, fixed a couple it got wrong, and excluded the object.assign rule since it gets the output on that one completely wrong

* chore: prefer object spread fix

replace Object.assign use with object spread, per the eslint rules

* chore: add import order lint rule

* chore: remove offending setState in componentWillUpdate

the code was doing nothing anyway, and was likely a holdover from some changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant