Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsible sidebar #3185

Merged
merged 5 commits into from
Mar 19, 2015
Merged

Collapsible sidebar #3185

merged 5 commits into from
Mar 19, 2015

Conversation

panda01
Copy link
Contributor

@panda01 panda01 commented Feb 26, 2015

Added a directive for collapsing sidebars. Closes #3037.

@panda01 panda01 added this to the 4.1.0 milestone Feb 26, 2015
@jthomassie
Copy link

@panda01 this looks good to me functionally. Stylistically (is that a word?), I think the width of the 'sidebar-collapser' feels a little tight and covers up the right edge of the 'sidebar-list'. Maybe it could be styled like the tab to open and close the 'spy panel'.
See what @rashidkpc thinks.

@jthomassie jthomassie assigned panda01 and unassigned jthomassie Feb 26, 2015
@panda01 panda01 assigned stormpython and unassigned panda01 Feb 26, 2015
@panda01 panda01 added the review label Feb 27, 2015
@panda01 panda01 assigned w33ble and stormpython and unassigned stormpython and w33ble Mar 2, 2015
@stormpython
Copy link
Contributor

@panda01 This LGTM, but I wonder when the screen size is reduced whether there is a need for the collapsible sidebar anymore. For example:

screen shot 2015-03-02 at 2 19 29 pm

In this situation the side bar is already collapsed. So, I do not think there is a need for the collapsible directive applied to the sidebar. See below.

screen shot 2015-03-02 at 2 18 42 pm

But it's certainly not a blocker. May want to ask @rashidkpc or @spalger.

@stormpython stormpython assigned panda01 and unassigned stormpython Mar 2, 2015
@stormpython stormpython removed the review label Mar 2, 2015
… the screen is too small, and hides the entire sidebar when it's collapsed and too small
@panda01
Copy link
Contributor Author

panda01 commented Mar 2, 2015

Smooth thanks for the review, I put a solution that I believe will work!

@panda01 panda01 assigned spalger and unassigned panda01 Mar 2, 2015
@rashidkpc rashidkpc removed this from the 4.1.0 milestone Mar 2, 2015
@panda01 panda01 assigned simianhacker and unassigned spalger Mar 19, 2015
@simianhacker
Copy link
Member

LGTM. Feel free to merge this.

panda01 added a commit that referenced this pull request Mar 19, 2015
@panda01 panda01 merged commit f8d8166 into elastic:master Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapsible left navigation in Discover screen
7 participants