Color Auto button inside Chart style should read "Color: Auto" #32558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
changed the title
alexwizp
requested changes
Mar 6, 2019
| @@ -36,7 +36,7 @@ export const SimpleTemplate = props => { | |||
| <span>Color </span> | |||
| </EuiFlexItem> | |||
| <EuiFlexItem grow={false}> | |||
| <EuiLink onClick={() => handlePlain('color', '#000000')}> | |||
| <EuiLink aria-label="Color: Auto" onClick={() => handlePlain('color', '#000000')}> | |||
There was a problem hiding this comment.
Color: Auto should be localized
See example:
aria-label={intl.formatMessage({ id: 'tsvb.percentile.percentileAriaLabel', defaultMessage: 'Percentile' })}
PhilippBaranovskiy
force-pushed
the
25508
branch
from
6f64bb2
to
e9e1c54
Compare
💚 Build Succeeded |
peteharverson
requested review from
peteharverson
and removed request for
jgowdyelastic and
peteharverson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #25508
Summary
Added aria-label attribute for Color: Auto.
Since the original code is without internationalization, I left it so as well.