Show "of #" in saved object editor list. #3565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. 👆 🚨 |
lukasolson
added a commit
that referenced
this pull request
Apr 9, 2015
Show "of #" in saved object editor list.
|
So... Apparently there is a little bug with this...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3554
The problem was that we were showing the list of the array in the tab title, but not the total hits. This changes the tab display to show "of #" (eg 100 of 2345) in the case that the total hist exceeds the list length. It also adds a short sentences to the intro to explain the behavior and the filter bar.