[feat] create additional http servers #36804

toddself · 2019-05-21T17:21:41Z

allow for additional http servers to be created, tracked and returned

Summary

This allows kibana plugins to create an additional http server with the
same options as the main server, but listening on a different port.

Closes #36713
Blocked by #37118

Dev Docs

New Platform plugins can now create additional HTTP servers on additional ports. Example:

class MyPlugin {
  setup({ http }) {
    this.additionalServer = http.createNewServer({ port: 3000 });
    this.additionalServer.registerRouter(new Router());
  }

  async start() {
    await this.additionalServer.start();
  }
}

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~This was checked for cross-browser compatibility, including a check against IE11~~
~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
~~This includes a feature addition or change that requires a release note and was labeled appropriately~~

elasticmachine · 2019-05-21T17:22:09Z

Pinging @elastic/kibana-platform

src/core/server/http/http_service.ts

eliperelman · 2019-05-21T17:30:19Z

In order for this PR to automatically close the mentioned issue #, you will need to put this in the summary. Also, could you add back in the rest of the information from the pull request template?

eliperelman

Just have a couple small requests.

src/core/server/http/http_service.ts

elasticmachine · 2019-05-21T18:32:41Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

src/core/server/http/http_service.test.ts

src/core/server/http/http_service.ts

elasticmachine · 2019-05-21T23:17:24Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-05-22T00:00:56Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-05-22T16:26:57Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

eliperelman

Just a couple minor changes, my review is approved once those are done.

src/core/server/http/http_service.mock.ts

src/core/server/http/http_service.ts

src/core/server/http/http_server.ts

src/core/server/http/http_service.test.ts

elasticmachine · 2019-05-23T19:39:48Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

In elastic#36804 we need to validate a `Partial<HttpConfig>` object which may or may not have all the required keys attached to it. This is the type of use-case for `Joi.reach`, so we should expose a reach-like method on the object validation class so that you can return the validator for a specific key on an object.

elasticmachine · 2019-05-24T18:40:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

* [feat] add reach-like functionality to object In #36804 we need to validate a `Partial<HttpConfig>` object which may or may not have all the required keys attached to it. This is the type of use-case for `Joi.reach`, so we should expose a reach-like method on the object validation class so that you can return the validator for a specific key on an object. * [fix] change to validateKey * [fix] use throw error matcher * [fix] use same interface for validate * [fix] change test name]

elasticmachine · 2019-05-29T15:14:59Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

joshdover

A few small things, good to merge once resolved.

src/core/server/http/http_server.ts

src/core/server/http/http_service.ts

elasticmachine · 2019-05-29T18:13:50Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-05-29T19:59:12Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* [feat] create additional http servers allow for additional http servers to be created, tracked and returned * respond to pr feedback * tweak test * update documentation * destructure port, remove unnecessary imports * [fix] export correct type * [feat] expose createNewServer to plugins * [fix] respond to pr feedback * todo: add schema validation & integration test * use reach * [fix] use validateKey to validate partial * [fix] change config shadowing * check kibana port & prevent shadowing * centralize start/stop for servers, add integration test * remove unnecessary property * never forget your await * remove option to pass config into start * fix pr feedback * fix documentation * fix test failures

mshustov · 2019-05-30T07:19:07Z

src/core/server/http/http_service.ts

-      isListening: () => this.httpServer.isListening(),
+      isListening: (port = 0) => {
+        const server = this.secondaryServers.get(port);
+        if (server) return server.isListening();


should we differentiate between primary server and secondary? that creates additional logic

i originally didn't differentiate them but thought we might want to since we might want ot know what the primary instance is (than again we could find the port for primary and get it that way).

anyway i created an issue for it #37695.

* [feat] create additional http servers allow for additional http servers to be created, tracked and returned * respond to pr feedback * tweak test * update documentation * destructure port, remove unnecessary imports * [fix] export correct type * [feat] expose createNewServer to plugins * [fix] respond to pr feedback * todo: add schema validation & integration test * use reach * [fix] use validateKey to validate partial * [fix] change config shadowing * check kibana port & prevent shadowing * centralize start/stop for servers, add integration test * remove unnecessary property * never forget your await * remove option to pass config into start * fix pr feedback * fix documentation * fix test failures

* [feat] create additional http servers (#36804) * [feat] create additional http servers allow for additional http servers to be created, tracked and returned * respond to pr feedback * tweak test * update documentation * destructure port, remove unnecessary imports * [fix] export correct type * [feat] expose createNewServer to plugins * [fix] respond to pr feedback * todo: add schema validation & integration test * use reach * [fix] use validateKey to validate partial * [fix] change config shadowing * check kibana port & prevent shadowing * centralize start/stop for servers, add integration test * remove unnecessary property * never forget your await * remove option to pass config into start * fix pr feedback * fix documentation * fix test failures * [fix] failing negation on merge

elasticmachine · 2019-07-09T17:02:43Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

toddself requested a review from a team as a code owner May 21, 2019 17:21

toddself added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label May 21, 2019

toddself added the v7.3.0 label May 21, 2019

joshdover added the v8.0.0 label May 21, 2019

joshdover reviewed May 21, 2019

View reviewed changes

src/core/server/http/http_service.ts Outdated Show resolved Hide resolved

eliperelman suggested changes May 21, 2019

View reviewed changes

src/core/server/http/http_service.ts Outdated Show resolved Hide resolved

src/core/server/http/http_service.ts Outdated Show resolved Hide resolved

toddself requested a review from eliperelman May 21, 2019 20:31

eliperelman reviewed May 21, 2019

View reviewed changes

src/core/server/http/http_service.test.ts Outdated Show resolved Hide resolved

src/core/server/http/http_service.ts Outdated Show resolved Hide resolved

src/core/server/http/http_service.ts Outdated Show resolved Hide resolved

src/core/server/http/http_service.ts Show resolved Hide resolved

toddself requested a review from eliperelman May 21, 2019 22:05

toddself force-pushed the multiple-http-service branch from 94a231b to 22f962a Compare May 21, 2019 22:41

toddself requested a review from joshdover May 21, 2019 22:42

toddself force-pushed the multiple-http-service branch from 22f962a to 60e072a Compare May 22, 2019 15:06

toddself mentioned this pull request May 22, 2019

[feat] proxy implementation #36907

Closed

13 tasks

eliperelman approved these changes May 22, 2019

View reviewed changes

src/core/server/http/http_service.mock.ts Outdated Show resolved Hide resolved

src/core/server/http/http_service.ts Outdated Show resolved Hide resolved

mshustov reviewed May 23, 2019

View reviewed changes

toddself force-pushed the multiple-http-service branch from 60e072a to 875e7e4 Compare May 23, 2019 17:57

toddself force-pushed the multiple-http-service branch from d779294 to 904be16 Compare May 24, 2019 17:22

toddself mentioned this pull request May 24, 2019

[feat] add reach-like functionality to object #37118

Merged

7 tasks

toddself force-pushed the multiple-http-service branch from 904be16 to c2489d2 Compare May 24, 2019 23:18

toddself added 2 commits May 29, 2019 07:39

centralize start/stop for servers, add integration test

9252c79

remove unnecessary property

6bb33b4

toddself force-pushed the multiple-http-service branch from 279d414 to 6bb33b4 Compare May 29, 2019 14:39

toddself added 2 commits May 29, 2019 09:50

never forget your await

d7e4044

remove option to pass config into start

920da22

joshdover approved these changes May 29, 2019

View reviewed changes

src/core/server/http/http_server.ts Outdated Show resolved Hide resolved

src/core/server/http/http_server.ts Outdated Show resolved Hide resolved

src/core/server/http/http_service.ts Outdated Show resolved Hide resolved

fix pr feedback

b361884

toddself added 2 commits May 29, 2019 11:17

fix documentation

6f0e5c9

fix test failures

c38727f

toddself merged commit 461a6c0 into elastic:master May 29, 2019

toddself deleted the multiple-http-service branch May 29, 2019 20:01

toddself mentioned this pull request May 29, 2019

[7.x] [feat] create additional http servers (#36804) #37421

Closed

mshustov reviewed May 30, 2019

View reviewed changes

toddself mentioned this pull request May 30, 2019

[7.x] [feat] create additional http servers (#36804) #37517

Merged

This was referenced May 31, 2019

Should we track seconardy servers separately from the primary instance? #37695

Closed

[KC] Implement secondary HTTP server for Proxy Plugin #37546

Closed

joshdover added the release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. label Jul 9, 2019

mshustov removed the v8.0.0 label Jul 31, 2019

mshustov mentioned this pull request Jul 31, 2019

revert PR 36804 'Create additional HTTP servers' #42333

Merged

3 tasks

mshustov added the reverted label Aug 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feat] create additional http servers #36804

[feat] create additional http servers #36804

toddself commented May 21, 2019 •

edited by joshdover

Loading

elasticmachine commented May 21, 2019

eliperelman commented May 21, 2019

eliperelman left a comment

elasticmachine commented May 21, 2019

elasticmachine commented May 21, 2019

elasticmachine commented May 22, 2019

elasticmachine commented May 22, 2019

eliperelman left a comment

elasticmachine commented May 23, 2019

elasticmachine commented May 24, 2019

elasticmachine commented May 29, 2019

joshdover left a comment

elasticmachine commented May 29, 2019

elasticmachine commented May 29, 2019

mshustov May 30, 2019

toddself May 31, 2019

elasticmachine commented Jul 9, 2019

[feat] create additional http servers #36804

[feat] create additional http servers #36804

Conversation

toddself commented May 21, 2019 • edited by joshdover Loading

Summary

Dev Docs

Checklist

For maintainers

elasticmachine commented May 21, 2019

eliperelman commented May 21, 2019

eliperelman left a comment

Choose a reason for hiding this comment

elasticmachine commented May 21, 2019

💔 Build Failed

elasticmachine commented May 21, 2019

💔 Build Failed

elasticmachine commented May 22, 2019

💔 Build Failed

elasticmachine commented May 22, 2019

💚 Build Succeeded

eliperelman left a comment

Choose a reason for hiding this comment

elasticmachine commented May 23, 2019

💔 Build Failed

elasticmachine commented May 24, 2019

💔 Build Failed

elasticmachine commented May 29, 2019

💔 Build Failed

joshdover left a comment

Choose a reason for hiding this comment

elasticmachine commented May 29, 2019

💔 Build Failed

elasticmachine commented May 29, 2019

💚 Build Succeeded

mshustov May 30, 2019

Choose a reason for hiding this comment

toddself May 31, 2019

Choose a reason for hiding this comment

elasticmachine commented Jul 9, 2019

💔 Build Failed

toddself commented May 21, 2019 •

edited by joshdover

Loading