Tilemap heatmap #3830
Tilemap heatmap #3830
Conversation
…map inputs, clean up method descriptions
…m all maps, added normalize heat data checkbox input, added destroy to _vislib_renderbot.js to properly destroy maps before draw method called which fixed fatal error after changing from heatmap to another maptype
….log, removed a multi-ternary, added tooltips to heatmap inputs
…ox for normalize input, added option for show tooltips
…ouple of methods to be faster
…s, applied nearestFeature and showTooltip methods to all map types
…s, applied nearestFeature and showTooltip methods to all map types
…or when data was not on map
… prelim test failures
…s to scale domain and range values
|
Clicking on the zoom to bounds button causes a fatal error:
|
| @@ -662,8 +900,7 @@ define(function (require) { | |||
| TileMap.prototype.destroy = function () { | |||
| if (this.popups) { | |||
| this.popups.forEach(function (popup) { | |||
| popup.elem.off('mouseover').off('mouseout'); | |||
| popup.layer.unbindPopup(popup.elem); | |||
| popup.off('mouseover').off('mouseout'); | |||
There was a problem hiding this comment.
popups is an array of objects returned from layer.on. I'm not 100% on what's happening here, but if this is a leaflet layer (as I'm assuming it is), does .off() work this way?
According to the docs, leaflet's .off needs the handler to properly unbind the event.
There was a problem hiding this comment.
From http://leafletjs.com/reference.html#events-removeeventlistener
If no function is specified, it will remove all the listeners of that particular event from the object"
This should be fine
|
Not a blocker, but there's a lot of options here with a wide range of values - it might be nice to add a *Reset to Defaults` button here. Could absolutely be a new issue though.
|
|
LGTM, giving to @simianhacker for last looks |
|
Defaults ticket here: #3864 |
|
It's kind of frustrating that changing any setting on the map resets the zoom level.
|
Tooltip is not using field formattersI have the following scripted field:
When I use that with the heat map I expect to get the
|
|
LGETM |
This is a replacement for #3589 which introduces a heatmap style mode to the tilemap. It fixes the last few issues I know of in that pull, mostly normalizing the tooltip function.