Upgarde enzyme to v3.10.0 #38766
Merged
Upgarde enzyme to v3.10.0 #38766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*update snapshots (React components which are using Memo()); *revert pending test in list_control_editor.test.js; *replace component.html() and component.text() function calls which expect null to component.isEmptyRender() for consistency
💔 Build Failed |
💔 Build Failed |
sulemanof
requested review from
spalger,
joshdover,
azasypkin,
mshustov,
maryia-lapata and
XavierM
sulemanof
commented
Jun 12, 2019
| @@ -59,7 +59,7 @@ describe('Toaster', () => { | |||
| if (toasts.length === 0) { | |||
| dispatch({ type: 'addToaster', toast: mockToast }); | |||
| } | |||
| }); | |||
| }, []); | |||
There was a problem hiding this comment.
@XavierM
I've added it because of previous version of enzyme had a gap in calling hooks.
Without adding call this effect only after the first render the test fails, because of when click the btn and dispatch deleteToaster -> the toasts array becomes empty and useEffect will return in the game and will add new toast.
💚 Build Succeeded |
sulemanof
added
release_note:skip
|
Pinging @elastic/kibana-platform |
💚 Build Succeeded |
💚 Build Succeeded |
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Jun 17, 2019
* Upgarde enzyme to v3.10.0 *update snapshots (React components which are using Memo()); *revert pending test in list_control_editor.test.js; *replace component.html() and component.text() function calls which expect null to component.isEmptyRender() for consistency # Conflicts: # x-pack/plugins/siem/public/components/toasters/index.test.tsx
sulemanof
added a commit
that referenced
this pull request
Jun 18, 2019
* Upgarde enzyme to v3.10.0 *update snapshots (React components which are using Memo()); *revert pending test in list_control_editor.test.js; *replace component.html() and component.text() function calls which expect null to component.isEmptyRender() for consistency # Conflicts: # x-pack/plugins/siem/public/components/toasters/index.test.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR updates airbnb/enzyme and dependent libs to the latest. It is necessary for enabling a unit test in
src/legacy/core_plugins/input_control_vis/public/components/editor/list_control_editor.test.js, which was disabled in #37064The PR includes next changes:
Memo());component.html()andcomponent.text()function callswhich expect
nullvalues tocomponent.isEmptyRender()for consistency - the discussion and an enzyme maintainer suggestionChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers