Markdown vis type np shim

.i18nrc.json

@@ -13,7 +13,7 @@
     "kbnDocViews": "src/legacy/core_plugins/kbn_doc_views",
     "embeddableApi": "src/legacy/core_plugins/embeddable_api",
     "kbnVislibVisTypes": "src/legacy/core_plugins/kbn_vislib_vis_types",
-    "markdownVis": "src/legacy/core_plugins/markdown_vis",
+    "visTypeMarkdown": "src/legacy/core_plugins/vis_type_markdown",
     "metricVis": "src/legacy/core_plugins/metric_vis",
     "vega": "src/legacy/core_plugins/vega",
     "tableVis": "src/legacy/core_plugins/table_vis",

src/legacy/core_plugins/markdown_vis/index.js → src/legacy/core_plugins/vis_type_markdown/index.ts

@@ -18,19 +18,19 @@
  */
 
 import { resolve } from 'path';
+import { Legacy } from '../../../../kibana';
+import { LegacyPluginApi } from '../../plugin_discovery/types';
 
-export default function (kibana) {
-
-  return new kibana.Plugin({
-
+// eslint-disable-next-line import/no-default-export
+export default function MarkdownVisTypePlugin(kibana: LegacyPluginApi) {
+  const config: Legacy.PluginSpecOptions = {
+    id: 'vis_type_markdown',
+    require: ['data', 'visualizations'],
     uiExports: {
-      visTypes: [
-        'plugins/markdown_vis/markdown_vis'
-      ],
-      interpreter: ['plugins/markdown_vis/markdown_fn'],
       styleSheetPaths: resolve(__dirname, 'public/index.scss'),
-    }
-
-  });
+      hacks: ['plugins/vis_type_markdown/index'],
+    },
+  };
 
+  return new kibana.Plugin(config);
 }

src/legacy/core_plugins/vis_type_markdown/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "vis_type_markdown",
+  "version": "kibana"
+}

src/legacy/core_plugins/vis_type_markdown/public/index.ts

@@ -0,0 +1,42 @@
+/*
+ * Licensed to Elasticsearch B.V. under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch B.V. licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+// @ts-ignore
+import { markdownVis } from './markdown_vis';
+// @ts-ignore
+import { kibanaMarkdown } from './markdown_fn';
+
+// @ts-ignore
+import { functionsRegistry } from '../../interpreter/public/registries';
+import { visualizations, VisualizationsSetup } from '../../visualizations/public';
+
+class VisTypeMarkdownPlugin {
+  constructor() {}
+
+  public setup(visualizationsSetup: VisualizationsSetup) {
+    visualizationsSetup.types.VisTypesRegistryProvider.register(() => markdownVis);
+    functionsRegistry.register(kibanaMarkdown);
+  }
+
+  public start() {}
+
+  public stop() {}
+}
+
+new VisTypeMarkdownPlugin().setup(visualizations);

src/legacy/core_plugins/markdown_vis/public/markdown_fn.test.js → src/legacy/core_plugins/vis_type_markdown/public/markdown_fn.test.ts

@@ -17,6 +17,7 @@
  * under the License.
  */
 
+// @ts-ignore
 import { functionWrapper } from '../../interpreter/test_helpers';
 import { kibanaMarkdown } from './markdown_fn';
 
@@ -28,8 +29,8 @@ describe('interpreter/functions#markdown', () => {
     markdown: '## hello _markdown_',
   };
 
-  it('returns an object with the correct structure', () => {
-    const actual = fn(undefined, args);
+  it('returns an object with the correct structure', async () => {
+    const actual = await fn(undefined, args);
     expect(actual).toMatchSnapshot();
   });
 });

src/legacy/core_plugins/markdown_vis/public/markdown_fn.js → src/legacy/core_plugins/vis_type_markdown/public/markdown_fn.ts

@@ -17,34 +17,58 @@
  * under the License.
  */
 
-import { functionsRegistry } from 'plugins/interpreter/registries';
 import { i18n } from '@kbn/i18n';
+import { ExpressionFunction, KibanaDatatable, Render } from '../../interpreter/types';
 
-export const kibanaMarkdown = () => ({
-  name: 'markdownVis',
+const name = 'markdownVis';
+
+export interface Arguments {
+  markdown: string;
+  fontSize: number;
+  openLinksInNewTab: boolean;
+}
+
+type Return = Promise<Render<{ visType: 'markdown'; visConfig: Arguments }>>;
+
+export const kibanaMarkdown = (): ExpressionFunction<
+  typeof name,
+  KibanaDatatable,
+  Arguments,
+  Return
+> => ({
+  name,
   type: 'render',
   context: {
     types: [],
   },
-  help: i18n.translate('markdownVis.function.help', {
-    defaultMessage: 'Markdown visualization'
+  help: i18n.translate('visTypeMarkdown.function.help', {
+    defaultMessage: 'Markdown visualization',
   }),
   args: {
     markdown: {
-      type: ['string'],
+      types: ['string'],
       aliases: ['_'],
       required: true,
+      help: i18n.translate('visTypeMarkdown.function.markdown.help', {
+        defaultMessage: 'Markdown to render',
+      }),
     },
     fontSize: {
       types: ['number'],
       default: 12,
+      help: i18n.translate('visTypeMarkdown.function.fontSize.help', {
+        defaultMessage: 'Sets the font size',
+      }),
     },
     openLinksInNewTab: {
       types: ['boolean'],
       default: false,
-    }
+      help: i18n.translate('visTypeMarkdown.function.openLinksInNewTab.help', {
+        defaultMessage: 'Opens links in new tab',
+      }),
+    },
   },
-  fn(context, args) {
+  async fn(context, args) {
     return {
       type: 'render',
       as: 'visualization',
@@ -53,9 +77,7 @@ export const kibanaMarkdown = () => ({
         visConfig: {
           ...args,
         },
-      }
+      },
     };
-  }
+  },
 });
-
-functionsRegistry.register(kibanaMarkdown);

src/legacy/core_plugins/vis_type_markdown/public/markdown_vis.ts

@@ -0,0 +1,54 @@
+/*
+ * Licensed to Elasticsearch B.V. under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch B.V. licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { i18n } from '@kbn/i18n';
+
+import { visFactory, DefaultEditorSize } from '../../visualizations/public';
+
+import { MarkdownVisWrapper } from './markdown_vis_controller';
+import markdownVisParamsTemplate from './markdown_vis_params.html';
+
+export const markdownVis = visFactory.createReactVisualization({
+  name: 'markdown',
+  title: 'Markdown',
+  isAccessible: true,
+  icon: 'visText',
+  description: i18n.translate('visTypeMarkdown.markdownDescription', {
+    defaultMessage: 'Create a document using markdown syntax',
+  }),
+  visConfig: {
+    component: MarkdownVisWrapper,
+    defaults: {
+      fontSize: 12,
+      openLinksInNewTab: false,
+      markdown: '',
+    },
+  },
+  editorConfig: {
+    optionsTemplate: markdownVisParamsTemplate,
+    enableAutoApply: true,
+    defaultSize: DefaultEditorSize.LARGE,
+  },
+  options: {
+    showTimePicker: false,
+    showFilterBar: false,
+  },
+  requestHandler: 'none',
+  responseHandler: 'none',
+});