Filter manager improvements \ bug fixes #41999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid firing update \ fetch events twice from filter manager, by making filter state manager use getFilters rathre than storing its own previous filters. - Don't fire fetch event when only disabled filters were changed - Replaced onlyDisabledChanged implementation with a more readable one (karma tests pass!) - Exported onlyDisabledChanged from data - Deleted unused only_state_changed
lizozom
added
release_note:skip
|
Pinging @elastic/kibana-app-arch |
lizozom
added
the
bug
|
it seems it doesn't fix #41204, i can still replicate that bug (go to visualize, open visualization, open dev tools, go to network tab, click refresh. two msearch requests are fired. appart from that LGTM, tested on chrome linux |
|
@ppisljar, spoke with @lukasolson |
💔 Build Failed |
…plugin/restore-fetch-update-diff
💔 Build Failed |
|
retest |
💚 Build Succeeded |
|
@ppisljar, @lukasolson updated his PR, to depend on this one and fix the bug in #41204. |
lukasolson
reviewed
Jul 26, 2019
src/legacy/core_plugins/data/public/filter/filter_manager/filter_state_manager.test.ts
Show resolved
Hide resolved
…plugin/restore-fetch-update-diff
💚 Build Succeeded |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Jul 28, 2019
* Filter manager improvements - Avoid firing update \ fetch events twice from filter manager, by making filter state manager use getFilters rathre than storing its own previous filters. - Don't fire fetch event when only disabled filters were changed - Replaced onlyDisabledChanged implementation with a more readable one (karma tests pass!) - Exported onlyDisabledChanged from data - Deleted unused only_state_changed * Delete empty afterEach
lizozom
pushed a commit
that referenced
this pull request
Jul 28, 2019
* Filter manager improvements - Avoid firing update \ fetch events twice from filter manager, by making filter state manager use getFilters rathre than storing its own previous filters. - Don't fire fetch event when only disabled filters were changed - Replaced onlyDisabledChanged implementation with a more readable one (karma tests pass!) - Exported onlyDisabledChanged from data - Deleted unused only_state_changed * Delete empty afterEach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to issues #41144 and #41204
Bugfix - Update and fetch events fired twice
Optimization - don't fetch data when changing disabled filters
onlyDisabledChanged implementation
onlyDisabledChangedimplementation to a more readable one (in TS).onlyDisabledChangedtests to jest.onlyDisabledChangedfrom data plugin, for any other plugin to useonlyStateChangedhelperSummarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers