Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move src/dev/run to @kbn/dev-utils #43387

Merged
merged 2 commits into from
Aug 16, 2019

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Aug 15, 2019

Moves the src/dev/run module into the @kbn/dev-utils package so it can more easily be used across Kibana, and so it can be used by the @kbn/test package.

@spalger spalger changed the title Refactor/move run to dev utils Move src/dev/run to @kbn/dev-utils Aug 15, 2019
@elasticmachine

This comment has been minimized.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger force-pushed the refactor/move-run-to-dev-utils branch from 137cf96 to ea60af0 Compare August 15, 2019 19:59
@spalger spalger marked this pull request as ready for review August 15, 2019 19:59
@spalger spalger requested a review from a team as a code owner August 15, 2019 19:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

Copy link
Member

@wayneseymour wayneseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger merged commit e8409c0 into elastic:master Aug 16, 2019
spalger pushed a commit to spalger/kibana that referenced this pull request Aug 16, 2019
* move src/dev/run into `@kbn/dev-utils`

* forgot to save a replacement

# Conflicts:
#	src/dev/renovate/run_build_renovate_config_cli.ts
spalger pushed a commit that referenced this pull request Aug 16, 2019
* move src/dev/run into `@kbn/dev-utils`

* forgot to save a replacement

# Conflicts:
#	src/dev/renovate/run_build_renovate_config_cli.ts
@spalger
Copy link
Contributor Author

spalger commented Aug 16, 2019

7.x/7.4: c1d6ec0
7.3: 0f77462

spalger pushed a commit to spalger/kibana that referenced this pull request Aug 16, 2019
* move src/dev/run into `@kbn/dev-utils`

* forgot to save a replacement

# Conflicts:
#	packages/kbn-dev-utils/src/index.ts
#	packages/kbn-test/src/functional_test_runner/cli.ts
#	src/dev/renovate/run_build_renovate_config_cli.ts
#	src/dev/run_i18n_check.ts
#	src/dev/run_i18n_extract.ts
#	src/dev/run_i18n_integrate.ts
spalger pushed a commit that referenced this pull request Aug 16, 2019
* move src/dev/run into `@kbn/dev-utils`

* forgot to save a replacement

# Conflicts:
#	packages/kbn-dev-utils/src/index.ts
#	packages/kbn-test/src/functional_test_runner/cli.ts
#	src/dev/renovate/run_build_renovate_config_cli.ts
#	src/dev/run_i18n_check.ts
#	src/dev/run_i18n_extract.ts
#	src/dev/run_i18n_integrate.ts
@spalger spalger deleted the refactor/move-run-to-dev-utils branch August 16, 2019 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants