Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code] try fix this test #43692

Merged
merged 3 commits into from
Sep 2, 2019
Merged

[Code] try fix this test #43692

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5b099c
[Code] try fix this test
Aug 21, 2019
71d4c74
Merge branch 'master' of github.com:elastic/kibana into enable_test
Aug 30, 2019
e924d66
Merge branch 'master' of github.com:elastic/kibana into enable_test
Sep 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions x-pack/legacy/plugins/code/server/lsp/workspace_handler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ test('should support spaces in workspace dir', async () => {
});

// FLAKY: https://github.com/elastic/kibana/issues/43655
test.skip('should support case-insensitive workspace dir', async () => {
const workspaceCaseInsensitive = path.join(baseDir, 'WorkSpace');
test('should support case-insensitive workspace dir', async () => {
const workspaceCaseInsensitive = path.join(baseDir, 'CamelCaseWorkSpace');
// test only if it's case-insensitive
const workspaceHandler = new WorkspaceHandler(
gitOps,
Expand All @@ -114,7 +114,9 @@ test.skip('should support case-insensitive workspace dir', async () => {
new ConsoleLoggerFactory()
);
const { repo, revision, file, uri } = makeAFile(workspaceCaseInsensitive);
if (fs.existsSync(workspaceCaseInsensitive.toLocaleLowerCase())) {
// normally this test won't run on linux since its filesystem are case sensitive
// So there is no 'CAMELCASEWORKSPACE' folder.
if (fs.existsSync(workspaceCaseInsensitive.toUpperCase())) {
const converted = handleResponseUri(workspaceHandler, uri.toLocaleLowerCase());
// workspace dir should be stripped
expect(converted).toBe(
Expand Down