Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test/x-pack] add matching functional_test_runner script #44939

Merged
merged 3 commits into from
Sep 11, 2019
Merged

[test/x-pack] add matching functional_test_runner script #44939

merged 3 commits into from
Sep 11, 2019

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Sep 5, 2019

This adds a matching scripts/functional_test_runner in x-pack.

Current workflows have caused some confusion with starting the functional test server in x-pack, then going back to the root directory to run the test runner. With this functional tests can be started from either the root directory (with config flags) or x-pack.

@jbudz jbudz added review Team:Operations Team label for Operations Team labels Sep 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

spalger
spalger approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbudz jbudz added release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v7.5.0 v8.0.0 labels Sep 11, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jbudz jbudz merged commit f8abcc4 into elastic:master Sep 11, 2019
jbudz added a commit that referenced this pull request Sep 11, 2019
@jbudz
[test/x-pack] add matching functional_test_runner script (#44939)
cd7ff10 
* [test/x-pack] add matching functional_test_runner script

* make readme consistent
@rayafratkina
Copy link
Contributor

@jbudz is dev_docs label here intentional? Are there API changes that external developers need to know about? If so, please add a DevDocs section...

This was referenced Aug 17, 2020
Closed
Closed
@jbudz
Copy link
Member Author

jbudz commented Aug 17, 2020 •
edited
Loading

Closes #41130

The contributing.md references were updated, but the guide docs are up to date. At a high level there were no forced API changes here. Dropping that label.

@jbudz jbudz added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. labels Aug 17, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 44939 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 19, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 44939 or prevent reminders by adding the backport:skip label.

3 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 44939 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 44939 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 44939 or prevent reminders by adding the backport:skip label.

@spalger spalger added the backport:skip This commit does not require backporting label Aug 25, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes review Team:Operations Team label for Operations Team v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbudz @elasticmachine @rayafratkina @kibanamachine @spalger