Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes references to Elasticsearch mapping types #47610

Merged
merged 17 commits into from
Nov 11, 2019
Merged

Removes references to Elasticsearch mapping types #47610

merged 17 commits into from
Nov 11, 2019

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Oct 8, 2019 •
edited by tylersmalley
Loading

Removes the remaining usage of elasticsearch types from Kibana. In 7.x types are deprecated, and 8.x they are removed, so this is needed to stay compliant with upcoming changes.

Closes #47217

@jbudz jbudz self-assigned this Oct 8, 2019
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@jbudz jbudz changed the title [test] rm types from es_archiver and saved object utils Remove types Oct 23, 2019
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jbudz jbudz marked this pull request as ready for review October 24, 2019 14:14
@jbudz jbudz requested review from a team as code owners October 24, 2019 14:14
@jbudz jbudz added review Team:Operations Team label for Operations Team labels Oct 24, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jbudz
Copy link
Member Author

jbudz commented Oct 28, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jbudz
Copy link
Member Author

jbudz commented Oct 28, 2019

One more action item, I'm looking now. #47610 (comment).

@spalger spalger mentioned this pull request Oct 28, 2019
Closed
@jbudz
Copy link
Member Author

jbudz commented Nov 1, 2019

@elasticmachine merge upstream

@jbudz
Copy link
Member Author

jbudz commented Nov 1, 2019

I'm going to be merging this shortly. The infra test change is unresolved, but I verified it's limited to a partial highlight. fragment_size is set to 1 with boundary set to word in the query, so as far as I can tell it was behaving improperly previously. I'll open a followup issue for the logs team to manage whether we want to change some of the parameters.

I checked for recent ES changes and nothing stood out. I did see some highlight changes going into lucene, but it's not clear to me whether they're related.

If anyone else digs in, resources:
https://lucene.apache.org/core/8_2_0/changes/Changes.html

cd x-pack && node scripts/functional_tests_server
cd .. && node scripts/es_archiver.js load $(pwd)/x-pack/test/functional/es_archives/infra/simple_logs/

http://localhost:5620/app/infra#/logs and click highlight -> generate_test_data/simple_logs

@jbudz jbudz mentioned this pull request Nov 1, 2019
Closed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

weltenwort
weltenwort approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra changes LGTM

@jbudz
Copy link
Member Author

jbudz commented Nov 11, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jbudz jbudz merged commit 1cc2a34 into elastic:master Nov 11, 2019
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 12, 2019
@jloleysens
Merge remote-tracking branch 'upstream/master' into test-1
37d4836 
* upstream/master:
  [ML] Make navigation in tests more stable (elastic#50132)
  Migrate authorization subsystem to the new platform.  (elastic#46145)
  Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063)
  Update dependency @elastic/charts to v14 (elastic#49947)
  [ML] Adding cloud specific ML node warning (elastic#50139)
  Fixing bugs in the Shareable Runtime (elastic#49965)
  Revert router base name for Uptime plugin to use hash in default path. (elastic#50095)
  Ability to have telemetry always opted in (elastic#49798)
  Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797)
  Removes references to Elasticsearch mapping types (elastic#47610)
  [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167)
  [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147)
  [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 12, 2019
@jloleysens
Merge remote-tracking branch 'upstream/master' into test-3
7b512ad 
* upstream/master:
  Move table-list-view to kibana-react (elastic#50046)
  [ML] Stats bar for data frame analytics (elastic#49464)
  [ML] Make navigation in tests more stable (elastic#50132)
  Migrate authorization subsystem to the new platform.  (elastic#46145)
  Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063)
  Update dependency @elastic/charts to v14 (elastic#49947)
  [ML] Adding cloud specific ML node warning (elastic#50139)
  Fixing bugs in the Shareable Runtime (elastic#49965)
  Revert router base name for Uptime plugin to use hash in default path. (elastic#50095)
  Ability to have telemetry always opted in (elastic#49798)
  Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797)
  Removes references to Elasticsearch mapping types (elastic#47610)
  [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167)
  [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147)
  [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 12, 2019
@jloleysens
Merge remote-tracking branch 'upstream/master' into np-migration/ua […
faa2676 
…skip ci]

* upstream/master:
  Move table-list-view to kibana-react (elastic#50046)
  [ML] Stats bar for data frame analytics (elastic#49464)
  [ML] Make navigation in tests more stable (elastic#50132)
  Migrate authorization subsystem to the new platform.  (elastic#46145)
  Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063)
  Update dependency @elastic/charts to v14 (elastic#49947)
  [ML] Adding cloud specific ML node warning (elastic#50139)
  Fixing bugs in the Shareable Runtime (elastic#49965)
  Revert router base name for Uptime plugin to use hash in default path. (elastic#50095)
  Ability to have telemetry always opted in (elastic#49798)
  Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797)
  Removes references to Elasticsearch mapping types (elastic#47610)
  [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167)
  [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147)
  [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Nov 14, 2019
@jbudz @chrisronline
Removes references to Elasticsearch mapping types (elastic#47610)
dbf091f 
* rm types

* fix infra/reindex test

* rm max_adjacency_matrix_filters

* lint

* more fixes

* comment return

* override documentation links

* typo

* return unfedined

* skip highlight test

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

@delvedor delvedor delvedor left review comments

@weltenwort weltenwort weltenwort approved these changes

@rudolf rudolf rudolf approved these changes

@spalger spalger spalger approved these changes

@jloleysens jloleysens jloleysens approved these changes

Assignees

@jbudz jbudz

Labels
release_note:skip Skip the PR/issue when compiling release notes review Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:Operations Team label for Operations Team v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove all elasticsearch typed endpoint usage
10 participants
@jbudz @elasticmachine @tylersmalley @sorenlouv @weltenwort @rudolf @spalger @delvedor @jloleysens @cjcenizal