Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.3] refactor failed_tests_reporter to use TS, no octokit (#46993) #47634

Merged
merged 3 commits into from
Oct 9, 2019

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Oct 8, 2019

Backports the following commits to 7.3:

* refactor failed_tests_reporter to use TS, no octokit

* update renovate config

* ensure that all kbn-test files are in ts project

* fix some type errors

* add some more tests

* [kbn-test/githubapi] cleanup and document

* collect log messages as strings instead of message objects

* ensure issue is open when updating body

* improve readability of getKibanaIssues

* expose axios helpers from dev-utils

* fix request params for fetching github issues and validate locally

* include a README for failed_tests_reporter

* improve axios error helpers

# Conflicts:
#	package.json
#	packages/kbn-dev-utils/src/axios/errors.ts
#	packages/kbn-dev-utils/src/index.ts
#	packages/kbn-dev-utils/src/kbn_client/kbn_client_requester.ts
#	packages/kbn-test/src/index.ts
#	packages/kbn-test/src/mocha/junit_report_generation.js
#	renovate.json5
#	src/dev/jest/junit_reporter.js
#	yarn.lock
@elasticmachine
Copy link
Contributor

💔 Build Failed

(cherry picked from commit 41134fe)
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger merged commit 066722f into elastic:7.3 Oct 9, 2019
@spalger spalger deleted the backport/7.3/pr-46993 branch October 9, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants